Re: networks and isolation/broadcast

2014-01-02 Thread Mike Tutkowski
Yeah, I'm not sure what's supposed to happen there. I guess it's supposed to enter the Starting state and then when it gets into the Running state is when we stop returning null (so I suppose it's OK). I'm just trying to figure how why my system VMs don't start. :) On Thu, Jan 2, 2014 at 1:36 P

Re: networks and isolation/broadcast

2014-01-02 Thread Daan Hoogland
I pushed an extra check to 4.3 I'm not sure what you mean with your last post Mike. if (proxy.getState() == VirtualMachine.State.Stopped) { _itMgr.advanceStart(proxy.getUuid(), null, null); proxy = _consoleProxyDao.findById(proxy.getId()); }

Re: networks and isolation/broadcast

2014-01-02 Thread Mike Tutkowski
I'm not that familiar with this part of the codebase, but the code in the "Stopped" if block looks incorrect when it assigns to proxy instead of doing a return. Thoughts? @Override public ConsoleProxyVO startProxy(long proxyVmId) { try { ConsoleProxyVO proxy = _cons

Re: networks and isolation/broadcast

2014-01-02 Thread Mike Tutkowski
I did notice one issue, but I don't think it's the cause because after correcting it the system VMs still do not start. In the wizard, I said I wanted to use local storage; however, I see the system.vm.use.local.storage property was still false after my cloud was created. I changed it to true and

Re: networks and isolation/broadcast

2014-01-02 Thread Mike Tutkowski
Cool...sounds good Does anyone have any thoughts on the system VM issue (with them not starting on Xen or KVM)? Console proxy is not in correct state to be started: Stopped On Thu, Jan 2, 2014 at 12:35 PM, Daan Hoogland wrote: > hey guys, > > have been sick in bed all day, sorry to react slowl

Re: networks and isolation/broadcast

2014-01-02 Thread Daan Hoogland
hey guys, have been sick in bed all day, sorry to react slowly. I saw your explanation Marcus and I should check for the case that only one of the two is null and return false. I will update and if you haven't already I will put in a fix. regards, Daan On Thu, Jan 2, 2014 at 8:55 AM, Marcus Sore

Re: networks and isolation/broadcast

2014-01-01 Thread Marcus Sorensen
There are some other issues near that commit as well. A fix for CLOUDSTACK-5502 that makes 'untagged' invalid needs to be backed out. On Thu, Jan 2, 2014 at 12:14 AM, Mike Tutkowski wrote: > Yeah, this does appear to be a bug. > > I re-ran the attempted creation of my CloudStack cloud with a di

Re: networks and isolation/broadcast

2014-01-01 Thread Mike Tutkowski
Yeah, this does appear to be a bug. I re-ran the attempted creation of my CloudStack cloud with a different XenServer host and was left in the same state (NPE). I plan to try this with KVM tomorrow (er, later today, I guess). On Wed, Jan 1, 2014 at 11:10 PM, Mike Tutkowski < mike.tutkow...@soli

Re: networks and isolation/broadcast

2014-01-01 Thread Mike Tutkowski
Looks like Daan added the method: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=utils/src/com/cloud/utils/net/NetUtils.java;h=a315b935495469648a0a82a25c39c9c53f0226f6;hp=11a483c3f7e420056dce7893a86946de5c40e244;hb=94abbb1367bc817bae98f369e78679f0ddb7727f;hpb=6897984970df145

Re: networks and isolation/broadcast

2014-01-01 Thread Mike Tutkowski
OK, thanks! On Wed, Jan 1, 2014 at 10:32 PM, Marcus Sorensen wrote: > git blame will show you the commit and committer. > > On Wed, Jan 1, 2014 at 10:19 PM, Mike Tutkowski > wrote: > > Yeah, but I wasn't sure of the coder's intend and if your replacement > code > > meet their expectations, so I

Re: networks and isolation/broadcast

2014-01-01 Thread Marcus Sorensen
git blame will show you the commit and committer. On Wed, Jan 1, 2014 at 10:19 PM, Mike Tutkowski wrote: > Yeah, but I wasn't sure of the coder's intend and if your replacement code > meet their expectations, so I didn't change it. I was hoping someone would > claim the code and chime in. :) > >

Re: networks and isolation/broadcast

2014-01-01 Thread Mike Tutkowski
Yeah, but I wasn't sure of the coder's intend and if your replacement code meet their expectations, so I didn't change it. I was hoping someone would claim the code and chime in. :) On Wed, Jan 1, 2014 at 10:16 PM, Marcus Sorensen wrote: > Yeah, it would be clearer if they were checked separatel

Re: networks and isolation/broadcast

2014-01-01 Thread Marcus Sorensen
Yeah, it would be clearer if they were checked separately: if (one == null || one.isEmpty()) { return true; } else if ( other == null || other.isEmpty()) [ return true; } or something like that. On Wed, Jan 1, 2014 at 10:00 PM, Mike Tutkowski wrote: > I should say this check doesn't hav

Re: networks and isolation/broadcast

2014-01-01 Thread Mike Tutkowski
I should say this check doesn't have to catch it...it might, but it doesn't have to (depends on the value of one). On Wed, Jan 1, 2014 at 9:59 PM, Mike Tutkowski wrote: > Yeah, in my case I'm just setting up a basic zone with a XenServer host. > > The code in NetUtils checks for null or "" on t

Re: networks and isolation/broadcast

2014-01-01 Thread Mike Tutkowski
Yeah, in my case I'm just setting up a basic zone with a XenServer host. The code in NetUtils checks for null or "" on the variable in question that's passed in. However, in a certain case, null for that variable can slip by and lead to a NPE. if ((one == null || one.equals(""))

Re: networks and isolation/broadcast

2014-01-01 Thread Marcus Sorensen
You can do "git blame (file)" and it will show you each line and the commit. You can also do a git log on the file. The issue may not be as obvious as that, though, there may be something totally unrelated causing that object to end up null in this code. Or it may be specific to your setup, some o

Re: networks and isolation/broadcast

2014-01-01 Thread Mike Tutkowski
This is in 4.3. I know the file is NetUtils, but I'm not sure in Git how to look at the history of a particular file like I could do in SVN. On Wed, Jan 1, 2014 at 3:55 PM, Marcus Sorensen wrote: > Which branch? I see these in master, you can check out the commit just > before these and see if

Re: networks and isolation/broadcast

2014-01-01 Thread Marcus Sorensen
Which branch? I see these in master, you can check out the commit just before these and see if it helps: commit b477e4e830597100f0c0171dd8e56f4033bd07aa Author: Daan Hoogland Date: Tue Dec 31 12:52:51 2013 +0100 some xtra cases commit 2cf356e047e26977c1d294fafc57e986c04fc5f4 Author: Daan

Re: networks and isolation/broadcast

2014-01-01 Thread Mike Tutkowski
Hey guys, The NPE I saw last night was related to "isolation id." Is it possible this NPE is related to something new that was put that you are talking about here? Thank! ERROR [c.c.a.ApiServer] (1583467451@qtp-185135566-2:ctx-ae5d80b2 ctx-5c12c4d9) unhandled exception executing api command: cre

Re: networks and isolation/broadcast

2014-01-01 Thread Marcus Sorensen
That's just it. The isolation type *is* provided when creating physical network. If I create a physical network with isolation type 'VXLAN', and then add traffic type of 'Public', it doesn't obey it. There's physical_networks and networks, when the zone is created, an entry goes in network that is

Re: networks and isolation/broadcast

2014-01-01 Thread Daan Hoogland
> While I've got your attention, what's the deal with isolation method vs > broadcast method? These are always set to the same thing as far as I've seen. I've been asking this but haven't found the answer yet. There is an overlap but both have some extra values the other hasn't. I don't like eit

Re: networks and isolation/broadcast

2013-12-31 Thread Marcus Sorensen
I suppose the answer might be to update the network with the proper isolation method when the traffic type is added. Look up the physical network's isolation method, grab network object for the public network, and set the right isolation. On Jan 1, 2014 12:46 AM, "Marcus Sorensen" wrote: > I ra

networks and isolation/broadcast

2013-12-31 Thread Marcus Sorensen
I ran into an issue today that I'm still trying to wrap my head around, and I wanted to bounce this off of you guys. I have a physical network whose isolation method is set to 'VXLAN' (v4.3+). I add my Public traffic type to it. I'd assume that nics generated for public traffic would have the sta