Re: n00b question about "code cleanup" fixes

2014-11-05 Thread Derrick Schneider
Thanks! Submitted. It's nothing major. Just something I noticed while I was in that code. On Wed, Nov 5, 2014 at 12:43 PM, Wido den Hollander wrote: > > > On 11/05/2014 07:28 PM, Derrick Schneider wrote: > > Hey, all. I just downloaded and got Cloudstack building on my dev > machine, > > and I h

Re: n00b question about "code cleanup" fixes

2014-11-05 Thread Wido den Hollander
On 11/05/2014 07:28 PM, Derrick Schneider wrote: > Hey, all. I just downloaded and got Cloudstack building on my dev machine, > and I had a question about a minor code-cleanup issue I saw. Specifically, > in DatabaseUpgradeChecker, there's this: > > if (Version.compare(trimmedCurrentVers

n00b question about "code cleanup" fixes

2014-11-05 Thread Derrick Schneider
Hey, all. I just downloaded and got Cloudstack building on my dev machine, and I had a question about a minor code-cleanup issue I saw. Specifically, in DatabaseUpgradeChecker, there's this: if (Version.compare(trimmedCurrentVersion, upgrades[upgrades.length - 1].getUpgradedVersion()) != 0