Re: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-29 Thread Prashanth Reddy Mandadi
Sent from my HTC - Reply message - From: "Alex Huang" To: "dev@cloudstack.apache.org" Subject: master build breaks at com.cloud.vpc.NetworkACLServiceTest Date: Wed, May 29, 2013 21:50 Daan, I'm new to mockito as well and I haven't had time to

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-29 Thread Alex Huang
dstack.apache.org' > Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest > > Alex, > > Thanks for the mockito lesson. I think a lot of us are now going to improve > their tests. > Can one make mockito forget the when-conditions? I would intuitive

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-29 Thread Daan Hoogland
not new to unit-tests sec but to mockito though) Hoogland -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: woensdag 29 mei 2013 16:34 To: Kishan Kavala; dev@cloudstack.apache.org Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest Kishan, The prob

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-29 Thread Alex Huang
turn(new NetworkACLItemVO()); _aclService.createNetworkACLItem(createACLItemCmd); } > -Original Message- > From: Kishan Kavala > Sent: Wednesday, May 29, 2013 4:48 AM > To: dev@cloudstack.apache.org > Cc: Alex Huang > Subject: RE: master build breaks at com.clou

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-29 Thread Daan Hoogland
esday, May 29, 2013 1:49 PM To: dev@cloudstack.apache.org Cc: Alex Huang Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest H, I hope this is what Alex means the test programmer needs. The order that is reported is as follows (I included the server test run

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-29 Thread Kishan Kavala
esday, May 29, 2013 1:49 PM To: dev@cloudstack.apache.org Cc: Alex Huang Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest H, I hope this is what Alex means the test programmer needs. The order that is reported is as follows (I included the server test run

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-29 Thread Daan Hoogland
;s machine but that time I also didn't know how this could have happened and I ended up reporting this to her and then after probably some amendments , unit tests compiled on all the machines. -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Wednesday, May

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-28 Thread Pranav Saxena
to her and then after probably some amendments , unit tests compiled on all the machines. -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Wednesday, May 29, 2013 12:05 AM To: dev@cloudstack.apache.org Subject: RE: master build breaks at com.cloud.vpc.NetworkACLS

Re: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-28 Thread Daan Hoogland
unit tests were executed so that the unit test writer > can try it. > > --Alex > > > -Original Message- > > From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] > > Sent: Monday, May 27, 2013 9:23 AM > > To: dev@cloudstack.apache.org > > Subject:

RE: PLEASE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-28 Thread Alex Huang
> Subject: PLEASE: master build breaks at > com.cloud.vpc.NetworkACLServiceTest > > I ran the test in eclipse, it passes, next I do a maven build in eclipse > which fails > on this test. How do I force it to pass, please. This is costing me serious > time. I > am not work

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-28 Thread Alex Huang
.org > Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest > > And if not how do I manipulate the order of tests? > > -Original Message- > From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] > Sent: maandag 27 mei 2013 17:02 > To: dev@cloudstack.apache.org > Su

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-28 Thread Pranav Saxena
I deployed the latest master today , infact moments back , but build was a success ! -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Tuesday, May 28, 2013 10:09 PM To: dev@cloudstack.apache.org Subject: Re: master build breaks at

Re: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-28 Thread Chip Childers
On Mon, May 27, 2013 at 04:23:20PM +, Daan Hoogland wrote: > And if not how do I manipulate the order of tests? IMO, tests should *never* require that they execute in a specific order. That's what the setup and teardown phases of test execution are for. If you find this is the issue, let's fi

RE: PLEASE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-27 Thread Pranav Saxena
(NetworkACLServ > iceTest.java:141) Thanks, Pranav -Original Message- From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] Sent: Monday, May 27, 2013 10:09 PM To: dev@cloudstack.apache.org Subject: PLEASE: master build breaks at com.cloud.vpc.NetworkACLServiceTest I ran the test

PLEASE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-27 Thread Daan Hoogland
...@schubergphilis.com] Sent: maandag 27 mei 2013 18:23 To: dev@cloudstack.apache.org Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest And if not how do I manipulate the order of tests? -Original Message- From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] Sent: maandag 27 mei

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-27 Thread Daan Hoogland
And if not how do I manipulate the order of tests? -Original Message- From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] Sent: maandag 27 mei 2013 17:02 To: dev@cloudstack.apache.org Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest Alex, Can this change

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-27 Thread Daan Hoogland
Alex, Can this change out of the box? I had the problem on a clean checkout of master. -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: maandag 27 mei 2013 15:55 To: dev@cloudstack.apache.org Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-27 Thread Alex Huang
gphilis.com] > Sent: Monday, May 27, 2013 2:37 AM > To: dev@cloudstack.apache.org > Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest > > Being in the habit of replying on my own mails as I seems to be on this list; > > This seems to be related to eclipse

RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-27 Thread Daan Hoogland
Hoogland [mailto:dhoogl...@schubergphilis.com] Sent: maandag 27 mei 2013 7:49 To: dev@cloudstack.apache.org Subject: master build breaks at com.cloud.vpc.NetworkACLServiceTest LS, Lately I've been getting, "com.cloud.exception.InvalidParameterValueException: ACL item with number 1 already exi

master build breaks at com.cloud.vpc.NetworkACLServiceTest

2013-05-26 Thread Daan Hoogland
LS, Lately I've been getting, "com.cloud.exception.InvalidParameterValueException: ACL item with number 1 already exists in ACL: null", while building cloudstack. I first thought it was my own hack so I don't know when it was introduced (it is in a clean master that it happens). The full surfir