Re: git commit: updated refs/heads/4.1 to f1c7f40

2013-04-04 Thread Rohit Yadav
On Thu, Apr 4, 2013 at 9:47 PM, Abhinandan Prateek < abhinandan.prat...@citrix.com> wrote: > I was wondering that during a clean install the template.sql inserts these > os types in DB and then runs the upgrade from 40 to 410. > Since I added these os types in 40-410 it throws duplicate key except

Re: git commit: updated refs/heads/4.1 to f1c7f40

2013-04-04 Thread Chip Childers
On Thu, Apr 04, 2013 at 04:17:26PM +, Abhinandan Prateek wrote: > I was wondering that during a clean install the template.sql inserts these > os types in DB and then runs the upgrade from 40 to 410. > Since I added these os types in 40-410 it throws duplicate key exception. > > I guess to fix

Re: git commit: updated refs/heads/4.1 to f1c7f40

2013-04-04 Thread Abhinandan Prateek
On 04/04/13 9:51 PM, "Chip Childers" wrote: >On Thu, Apr 04, 2013 at 04:17:26PM +, Abhinandan Prateek wrote: >> I was wondering that during a clean install the template.sql inserts >>these >> os types in DB and then runs the upgrade from 40 to 410. >> Since I added these os types in 40-410 i

Re: git commit: updated refs/heads/4.1 to f1c7f40

2013-04-04 Thread Chip Childers
On Thu, Apr 04, 2013 at 04:17:26PM +, Abhinandan Prateek wrote: > I was wondering that during a clean install the template.sql inserts these > os types in DB and then runs the upgrade from 40 to 410. > Since I added these os types in 40-410 it throws duplicate key exception. > > I guess to fix

Re: git commit: updated refs/heads/4.1 to f1c7f40

2013-04-04 Thread Abhinandan Prateek
I was wondering that during a clean install the template.sql inserts these os types in DB and then runs the upgrade from 40 to 410. Since I added these os types in 40-410 it throws duplicate key exception. I guess to fix this we need to remove this os type from the template instead of 40 to 410 up

Re: git commit: updated refs/heads/4.1 to f1c7f40

2013-04-04 Thread Abhinandan Prateek
Chip, Thanks for reverting. -Abhi On 04-Apr-2013, at 7:30 PM, "Chip Childers" wrote: > I've reverted that commit from 4.1. > > Abhi, please correct the change and commit to master. Please then > provide either a Patch Request email for me to cherry-pick over to the > 4.1 branch, or submit

Re: git commit: updated refs/heads/4.1 to f1c7f40

2013-04-04 Thread Abhinandan Prateek
Yes, I will take a look. On 04-Apr-2013, at 7:27 PM, "Chip Childers" wrote: > Abhi, > > Can you please review? This is now a blocker. > > On Thu, Apr 4, 2013 at 9:25 AM, Milamber wrote: >> >> >> Le 04/04/2013 05:51, aprat...@apache.org a ecrit : >> >>> Updated Branches: >>> refs/heads

Re: git commit: updated refs/heads/4.1 to f1c7f40

2013-04-04 Thread Chip Childers
I've reverted that commit from 4.1. Abhi, please correct the change and commit to master. Please then provide either a Patch Request email for me to cherry-pick over to the 4.1 branch, or submit a reviewboard entry for me to apply to 4.1. Thanks! On Thu, Apr 4, 2013 at 9:56 AM, Chip Childers w

Re: git commit: updated refs/heads/4.1 to f1c7f40

2013-04-04 Thread Chip Childers
Abhi, Can you please review? This is now a blocker. On Thu, Apr 4, 2013 at 9:25 AM, Milamber wrote: > > > Le 04/04/2013 05:51, aprat...@apache.org a ecrit : > >> Updated Branches: >>refs/heads/4.1 489010123 -> f1c7f4022 >> >> >> bug CLOUDSTACK-1842: adding the missing os type in upgrade sc

Re: git commit: updated refs/heads/4.1 to f1c7f40

2013-04-04 Thread Milamber
Le 04/04/2013 05:51, aprat...@apache.org a ecrit : Updated Branches: refs/heads/4.1 489010123 -> f1c7f4022 bug CLOUDSTACK-1842: adding the missing os type in upgrade script Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/clo