Re: Yet another mail on code quality

2014-02-26 Thread Hugo Trippaers
Thank Rajani! I’ve put the information on using FindBugs here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+FindBugs Cheers, Hugo On 26 feb. 2014, at 07:31, Rajani Karuturi wrote: > intellij findbugs plugin can be downloaded @ > http://plugins.jetbrains.com/plugin/3847 > onc

Re: Yet another mail on code quality

2014-02-25 Thread Rajani Karuturi
intellij findbugs plugin can be downloaded @ http://plugins.jetbrains.com/plugin/3847 once its installed, you can right click on the file -> FindBugs -> Analyze current file This will show the results in the find bugs console with a nice explanation for each error. you could also run $mvn findb

Re: Yet another mail on code quality

2014-02-25 Thread Abhinandan Prateek
Hugo, It will benefit the community if you can advise on how to setup the find bug tool. Is there a wiki on how to use find bug ? I know some tools that you can install on eclipse, but not sure about intellij etc. -abhi On 24/02/14 9:44 pm, "Hugo Trippaers" wrote: >Guys, > >Please pay atten

Re: Yet another mail on code quality

2014-02-24 Thread Marcus
- >> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers >> Sent: Monday, February 24, 2014 8:15 AM >> To: >> Subject: Yet another mail on code quality >> >> Guys, >> >> Please pay attention to the code you are committing. Today i f

RE: Yet another mail on code quality

2014-02-24 Thread Alex Huang
love is necessary. --Alex > -Original Message- > From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers > Sent: Monday, February 24, 2014 8:15 AM > To: > Subject: Yet another mail on code quality > > Guys, > > Please pay attention to the code

Re: Yet another mail on code quality

2014-02-24 Thread Laszlo Hornyak
Hi, Guys if you feel like, look around in sonar sometimes, it registers and tracks tons of such issues (and the app is cool, nice and super-trendy) https://analysis.apache.org/dashboard/index/100206 For incorrect use of == operator, sonar knows 14 more cases in ACS, There are some that "not nice

Yet another mail on code quality

2014-02-24 Thread Hugo Trippaers
Guys, Please pay attention to the code you are committing. Today i fixed a number of issues that were introduced in recent code, these are bugs that could have been prevented from entering master by either testing or running the findbugs checks. One was committed directly, the other one through