Re: Working with a 'PendingReleaseNotes' file

2018-06-28 Thread Wido den Hollander
apache.org; Daan Hoogland > Cc: Rafael Weingärtner > Subject: Re: Working with a 'PendingReleaseNotes' file > > > > On 06/21/2018 05:13 PM, Daan Hoogland wrote: >> Wido, I like the idea that we can generate from git what has happened since >> last time. I als

Re: Working with a 'PendingReleaseNotes' file

2018-06-21 Thread Rohit Yadav
Looks like a good idea, +1. - Rohit <https://cloudstack.apache.org> From: Wido den Hollander Sent: Friday, June 22, 2018 12:13:49 AM To: dev@cloudstack.apache.org; Daan Hoogland Cc: Rafael Weingärtner Subject: Re: Working with a 'PendingRelease

Re: Working with a 'PendingReleaseNotes' file

2018-06-21 Thread Wido den Hollander
On 06/21/2018 05:13 PM, Daan Hoogland wrote: > Wido, I like the idea that we can generate from git what has happened since > last time. I also recognise that we don't do that properly all the time. True. But a bunch of commits don't akways tell the exact story. Well, they do, but not for the en

Re: Working with a 'PendingReleaseNotes' file

2018-06-21 Thread Daan Hoogland
Wido, I like the idea that we can generate from git what has happened since last time. I also recognise that we don't do that properly all the time. What this comes down to is discipline, however we implement it. Deciding if a change is big enough would be up to both the author and the reviewer and

Re: Working with a 'PendingReleaseNotes' file

2018-06-20 Thread Wido den Hollander
On 06/20/2018 07:53 AM, Rafael Weingärtner wrote: > It seems so. It can then be a part of the PR. I mean, in the PR we could > require a commit that updates this file. Yes, that would be the thing. When you send a PR with a change that is 'big enough' you also include updating the Pending Relea

Re: Working with a 'PendingReleaseNotes' file

2018-06-19 Thread Rafael Weingärtner
It seems so. It can then be a part of the PR. I mean, in the PR we could require a commit that updates this file. Of course, we need to discuss if all PRs should update it, or only important things should go in. +1 On Tue, Jun 19, 2018 at 11:00 PM, Wido den Hollander wrote: > Hi, > > At the Cep

Working with a 'PendingReleaseNotes' file

2018-06-19 Thread Wido den Hollander
Hi, At the Ceph project we work with a Pending Release Notes [0]. The idea is that if a developer writes a new feature or fixes something that changes functionality (or adds one) she/he also updates the PendingReleaseNotes file. That way when a new version is released it's easier for the Release