Re: VMware snapshot question

Mike, Thanks for digging into the details, I’ll check it out after I’m done with my current things in hand Kelven On 1/7/14, 11:50 AM, "Mike Tutkowski" wrote: >Hi Kelven, > >I checked in ecd4a9c6424be73b24a44c73f04c67c47e1611e8. > >Creating, deleting, and reverting to VMware snapshots appears

Re: VMware snapshot question

Hi Kelven, I checked in ecd4a9c6424be73b24a44c73f04c67c47e1611e8. Creating, deleting, and reverting to VMware snapshots appears to work now, but feel free to try it out of course. :) Talk to you later On Tue, Jan 7, 2014 at 11:31 AM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Loo

Re: VMware snapshot question

Looks like deleting a VMware snapshot was suffering from the same problem as creating a VMware snapshot. I was able to solve both problems the same way. Now I'm going to look into reverting to a VMware snapshot. On Tue, Jan 7, 2014 at 10:31 AM, Mike Tutkowski < mike.tutkow...@solidfire.com> wro

Re: VMware snapshot question

I logged a bug for this: 1. CLOUDSTACK-5823 I assigned this to myself. I believe I've corrected the issue with taking a VMware snapshot, but I want to look into the delete and revert code, as well. On Tue, Jan 7, 2014 at 12:20 AM, Mi

Re: VMware snapshot question

If it's true that only the last iteration "counts," couldn't we just grab the last item in this list?: List> vmdkFiles = vmMo. getDiskDatastorePathChain(vdisks[i], false); On Tue, Jan 7, 2014 at 12:19 AM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Hi Kelven, > > I've been playing a

Re: VMware snapshot question

Hi Kelven, I've been playing around with some code to fix this VMware-snapshot issue. Probably won't have it done until tomorrow, but I wanted to ask you about this code: for (int i = 0; i < vdisks.length; i++) { List> vmdkFiles = vmMo.getDiskDatastorePathChai

Re: VMware snapshot question

Ignore my question about coming up with a baseName. I see now that volumeTO is not available in the first for loop. I do think the key and value we have in the map, though, is incorrect. What do you think? On Mon, Jan 6, 2014 at 10:43 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote:

Re: VMware snapshot question

Hi Kelven, To give you an idea visually what I am referring to, please check out this screen capture: http://i.imgur.com/ma3FE9o.png The key is "i-2" (part of the folder for the VMDK file). The value contains the folder the VMDK file is in. Since the path column for VMware volumes in the DB doe

Re: VMware snapshot question

Thanks for the info, Kelven. I believe we have a serious bug then as null is being assigned to newPath when a VMware snapshot is being taken (this is in 4.3, by the way). I was trying to fix an issue with VMware snapshots and managed storage and happened upon this. If you have a moment, you migh

Re: VMware snapshot question

On 1/6/14, 5:33 PM, "Mike Tutkowski" wrote: >Actually, the more I look at this code, the more I think perhaps VMware >snapshots are broken because the newPath field should probably not be >assigned null after creating a new VMware snapshot >(I'm thinking the intend >is to replace the other pa

Re: VMware snapshot question

Actually, the more I look at this code, the more I think perhaps VMware snapshots are broken because the newPath field should probably not be assigned null after creating a new VMware snapshot (I'm thinking the intend is to replace the other path with a new path that refers to the delta file that w

Re: VMware snapshot question

In short, I believe we can remove mapNewDisk and just assign null to newPath. This will keep the existing path for the volume in question (in the volumes table) in the same state as it was before we created a VMware snapshot, which I believe is the intent anyways. Thoughts on that? On Mon, Jan 6

VMware snapshot question

Hi, I was wondering about the following code in VmwareStorageManagerImpl. It is in the CreateVMSnapshotAnswer execute(VmwareHostService hostService, CreateVMSnapshotCommand cmd) method. The part I wonder about is in populating the mapNewDisk map. For disks like the following: i-2-9-VM/fksjfaklsj