Re: Strange if else under LibvirtStorageAdaptor.java[lines 1203-1206]

2014-11-10 Thread Wido den Hollander
Cc: shadow...@gmail.com > Subject: Re: Strange if else under LibvirtStorageAdaptor.java[lines 1203-1206] > > On 11/03/2014 10:05 AM, Santhosh Edukulla wrote: >> Team, >> >> Either of the paths are doing the same thing for below if else, please >> check. This is ob

RE: Strange if else under LibvirtStorageAdaptor.java[lines 1203-1206]

2014-11-10 Thread Santhosh Edukulla
...@widodh.nl] Sent: Monday, November 03, 2014 5:27 AM To: Santhosh Edukulla; dev@cloudstack.apache.org Cc: shadow...@gmail.com Subject: Re: Strange if else under LibvirtStorageAdaptor.java[lines 1203-1206] On 11/03/2014 10:05 AM, Santhosh Edukulla wrote: > Team, > > Either of the paths are

Re: Strange if else under LibvirtStorageAdaptor.java[lines 1203-1206]

2014-11-09 Thread Daan Hoogland
Santhosh, Do a git blame and give us some file / line no. So we can make sense. On Mon, Nov 3, 2014 at 11:27 AM, Wido den Hollander wrote: > > > On 11/03/2014 10:05 AM, Santhosh Edukulla wrote: >> Team, >> >> Either of the paths are doing the same thing for below if else, please >> check. This

Re: Strange if else under LibvirtStorageAdaptor.java[lines 1203-1206]

2014-11-03 Thread Wido den Hollander
On 11/03/2014 10:05 AM, Santhosh Edukulla wrote: > Team, > > Either of the paths are doing the same thing for below if else, please check. > This is observed under master. > I think that is a weird merge thing somewhere. I don't see any reason why this if statement is there. Wido > if (src

Strange if else under LibvirtStorageAdaptor.java[lines 1203-1206]

2014-11-03 Thread Santhosh Edukulla
Team, Either of the paths are doing the same thing for below if else, please check. This is observed under master. if (srcPool.getType() != StoragePoolType.RBD) { newDisk = destPool.createPhysicalDisk(name, Storage.ProvisioningType.THIN, disk.getVirtualSize());