Re: KVM: Out of subnet 'secondary' IPs for Virtual Machines (Anycast/floating IPs)

2022-01-19 Thread Daan Hoogland
hing the ipset. > >> > >> Name: i-79-1328-VM > >> Type: hash:ip > >> Revision: 4 > >> Header: family inet hashsize 1024 maxelem 65536 > >> Size in memory: 248 > >> References: 5 > >> Number of entries: 1 > >> Members: >

Re: KVM: Out of subnet 'secondary' IPs for Virtual Machines (Anycast/floating IPs)

2022-01-19 Thread Wido den Hollander
gt; Name: i-79-1328-VM >> Type: hash:ip >> Revision: 4 >> Header: family inet hashsize 1024 maxelem 65536 >> Size in memory: 248 >> References: 5 >> Number of entries: 1 >> Members: >> 62.221.XXX.11 >> >> I want to add /32 and /128 ad

Re: KVM: Out of subnet 'secondary' IPs for Virtual Machines (Anycast/floating IPs)

2022-01-17 Thread Wido den Hollander
to the VM, but this is not allowed by the API as the secondary IPs you want to add should always come from the subnet configured for that network. I do not want to turn off security grouping as this poses other potential issues. Solutions I see: - Add global/account/domain setting which allows arbi

Re: KVM: Out of subnet 'secondary' IPs for Virtual Machines (Anycast/floating IPs)

2022-01-17 Thread Wei ZHOU
eferences: 5 > Number of entries: 1 > Members: > 62.221.XXX.11 > > I want to add /32 and /128 addresses to this subnet so that the SG does > not filter away this traffic. > > They could be added as a secondary IP to the VM, but this is not allowed > by the API as the seco

Re: KVM: Out of subnet 'secondary' IPs for Virtual Machines (Anycast/floating IPs)

2022-01-17 Thread Daan Hoogland
ffic. > > They could be added as a secondary IP to the VM, but this is not allowed > by the API as the secondary IPs you want to add should always come from > the subnet configured for that network. > > I do not want to turn off security grouping as this poses other > potential i

KVM: Out of subnet 'secondary' IPs for Virtual Machines (Anycast/floating IPs)

2022-01-17 Thread Wido den Hollander
ut this is not allowed by the API as the secondary IPs you want to add should always come from the subnet configured for that network. I do not want to turn off security grouping as this poses other potential issues. Solutions I see: - Add global/account/domain setting which allows arbitrary

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1309 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-16 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-172261610 I agree we need to fix some issues like this , which is difficult to be reproduced but it is obviously an issue from code view. --- If your project is set up f

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-16 Thread wido
, but I can't. I can just tell you that by looking at the code this was a stupid thing which wasn't caught during the addition of secondary IPs. Our logs were full with Python stack traces and they are now gone :) --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-06 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169320044 @remibergsma Can we merge this one? It fixes a bug. To clarify, this is how the method has been defined: def default_network_rules(vm_name, vm_id, vm_i

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-06 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169267155 LGTM, just code review. simple but really make sense. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-05 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169134133 @DaanHoogland No idea. Might work with Xen if we manage those Instances through libvirt. But in case of KVM we can probably do this with libvirt. Might need to patches

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-05 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169133424 @wido will your proposal from CLOUDSTACK-1164 work for other hypervisors as well? --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-05 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169117271 @DaanHoogland I agree, this script isn't the best in the world. In my opinion we should offload this work to libvirt: - http://libvirt.org/formatnwfilter.ht

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-05 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169095187 @wido My point exactly. 10 lines up a conditional should guard the split() call --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-05 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169095290 btw LGTM if you don't want to improve further. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-05 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169069686 Forgot to add, pylint still works fine. It scores 3.54/10. Not great, but a lint check still succeeds. --- If your project is set up for it, you can reply to this ema

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-05 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169067941 @DaanHoogland We do not have any unit testing in place for Python. If you look just 10 lines up you see the method being called exactly that way. Without this

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-05 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169066689 simple fix but a test on the contents in the called method makes sense as well. Not sure how to test. --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-05 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169063660 @DaanHoogland @remibergsma @resmo Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

2016-01-05 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1309 CLOUDSTACK-9210: Pass secondary IPs to default_network_rules() function This is a mandatory argument but it was NOT passed which caused the re-programming of security groups to fail

Re: [ACS4.4][TestPlanReview]Configuring load balancing rules for VM nic secondary ips

2014-04-08 Thread Jayapal Reddy Uradi
citrix.com>> wrote: Hi , I have written test cases for the feature “Configuring LB rules for VM NIC secondary IPs” Please review it and provide the comments. https://cwiki.apache.org/confluence/display/CLOUDSTACK/TestPlan+:Configuring+load+balancing+rules+for+VM+nic+secondary+ips Thanks, Manasa

[ACS4.4][TestPlanReview]Configuring load balancing rules for VM nic secondary ips

2014-04-08 Thread Manasa Veloori (3P)
Hi , I have written test cases for the feature "Configuring LB rules for VM NIC secondary IPs" Please review it and provide the comments. https://cwiki.apache.org/confluence/display/CLOUDSTACK/TestPlan+:Configuring+load+balancing+rules+for+VM+nic+secondary+ips Thanks, Manasa

Re: [PROPOSAL] load balancing configuration for VM nic secondary ips

2014-02-07 Thread Sheng Yang
5:11 AM, "Jayapal Reddy Uradi" > wrote: > > >Hi, > > > >Multiple ips per nic feature allows user to acquire more ip address on vm > >nic. > >On these ip addresses user able to configure PF and static NAT. > > > >With this feature u

Re: [PROPOSAL] load balancing configuration for VM nic secondary ips

2014-02-07 Thread Chiradeep Vittal
figure the load balancing rules for vm >secondary ips also. > >Please review the below and give your comments. >https://cwiki.apache.org/confluence/display/CLOUDSTACK/Configuring+load+ba >lancing+rules+for+VM+nic+secondary+ips > >Ticket id: >CLOUDSTACK-2692 > > >Thanks, >Jayapal

Re: [PROPOSAL] load balancing configuration for VM nic secondary ips

2014-02-07 Thread Daan Hoogland
user able to configure PF and static NAT. >> >> With this feature user can also configure the load balancing rules for vm >> secondary ips also. >> >> Please review the below and give your comments. >> https://cwiki.apache.org/confluence/display/CLOUDSTACK/

Re: [PROPOSAL] load balancing configuration for VM nic secondary ips

2014-02-07 Thread Daan Hoogland
wrote: > Hi, > > Multiple ips per nic feature allows user to acquire more ip address on vm nic. > On these ip addresses user able to configure PF and static NAT. > > With this feature user can also configure the load balancing rules for vm > secondary ips also. > > Pleas

[PROPOSAL] load balancing configuration for VM nic secondary ips

2014-02-06 Thread Jayapal Reddy Uradi
Hi, Multiple ips per nic feature allows user to acquire more ip address on vm nic. On these ip addresses user able to configure PF and static NAT. With this feature user can also configure the load balancing rules for vm secondary ips also. Please review the below and give your comments

Re: Review Request: Updated account and domain id for nic secondary ips for shared networks

2013-06-11 Thread Abhinandan Prateek
ne 11, 2013, 6:24 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Murali Reddy. > > > Description > --- > > Updated account and domain id for nic secondary ips for shared networks. > Fixed by getting accoundId and domainId from the caller instead of

Re: Review Request: Updated account and domain id for nic secondary ips for shared networks

2013-06-10 Thread Jayapal Reddy
ly, visit: > https://reviews.apache.org/r/11458/ > --- > > (Updated May 28, 2013, 7:27 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Murali Reddy. > > > Description > --- > > Updated accoun

Re: Review Request: Updated account and domain id for nic secondary ips for shared networks

2013-06-10 Thread Jayapal Reddy
Prateek and Murali Reddy. Changes --- Updated to ipOwner Description --- Updated account and domain id for nic secondary ips for shared networks. Fixed by getting accoundId and domainId from the caller instead of network This addresses bug CLOUDSTACK-2609. Diffs (updated

Re: Review Request: Updated account and domain id for nic secondary ips for shared networks

2013-06-03 Thread Murali Reddy
.org/r/11458/ > --- > > (Updated May 28, 2013, 7:27 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Murali Reddy. > > > Description > --- > > Updated account and domain id for nic secondary ips for shared networks. > Fixed by gettin

Review Request: Updated account and domain id for nic secondary ips for shared networks

2013-05-28 Thread Jayapal Reddy
. Description --- Updated account and domain id for nic secondary ips for shared networks. Fixed by getting accoundId and domainId from the caller instead of network This addresses bug CLOUDSTACK-2609. Diffs - server/src/com/cloud/network/NetworkServiceImpl.java f880bcc Diff: https

Secondary IPs

2013-04-03 Thread Maurice Lawler
Hello,As I have been told by countless folks, it's next to impossible to have CS assign another IP address to an existing instance.Yesterday in #CloudStack was I provided this link: http://markmail.org/message/bt7pqnen26v2o63kMy question is now this, how can I disable iptables / or whatever network