Re: S3 as secondary storage is broken in master

2013-11-06 Thread Min Chen
":6,"vmName":"i-1-6-VM","accountId":1,"format":"QCOW2","id":6," >hypervisorType":"KVM"}},"executeInSequence":true,"wait":10800}}] >} > >2013-11-06 22:01:44,683 DEBUG [cloud.agent.Agent] >(agentRe

Re: S3 as secondary storage is broken in master

2013-11-06 Thread Marcus Sorensen
quence":true,"wait":10800}}] > } > > 2013-11-06 22:01:44,683 DEBUG [cloud.agent.Agent] > (agentRequest-Handler-5:null) Processing command: > org.apache.cloudstack.storage.command.CopyCommand > > 2013-11-06 22:01:44,684 DEBUG [cloud.agent.Agent] > (agentRequest

Re: S3 as secondary storage is broken in master

2013-11-06 Thread Marcus Sorensen
Id":1,"format":"QCOW2","id":6,"hypervisorType":"KVM"}},"executeInSequence":true,"wait":10800}}] } 2013-11-06 22:01:44,683 DEBUG [cloud.agent.Agent] (agentRequest-Handler-5:null) Processing command: org.apache.cloudstack.

Re: S3 as secondary storage is broken in master

2013-11-02 Thread Min Chen
he.org>" mailto:dev@cloudstack.apache.org>>, "SuichII, Christopher" mailto:chris.su...@netapp.com>>, Edison Su mailto:edison...@citrix.com>> Subject: Re: S3 as secondary storage is broken in master OK. I was thinking that S3 was acting as secondary storage now but

Re: S3 as secondary storage is broken in master

2013-11-02 Thread Marcus Sorensen
OK. I was thinking that S3 was acting as secondary storage now but really it still requires NFS as the intermediary, hence the "image cache". In that case your suggestion would work. On Nov 2, 2013 10:10 AM, "Min Chen" wrote: > No, Marcus. That piece of code worked in 4.2 for S3. Note that image

Re: S3 as secondary storage is broken in master

2013-11-02 Thread Min Chen
No, Marcus. That piece of code worked in 4.2 for S3. Note that image ache store is also NfsTO. Thanks -min Sent from my iPhone > On Nov 2, 2013, at 7:18 AM, "Marcus Sorensen" wrote: > > My only issue is that I believe copyTemplateToPrimaryStorage fails if > the source datastore is not NfsTO,

Re: S3 as secondary storage is broken in master

2013-11-02 Thread Marcus Sorensen
My only issue is that I believe copyTemplateToPrimaryStorage fails if the source datastore is not NfsTO, so I'm not sure if this change will do anything, or where S3 copy is actually handled. se copyTemplateToPrimaryStorage: KVM: if (!(imageStore instanceof NfsTO)) { return ne

S3 as secondary storage is broken in master

2013-11-01 Thread Min Chen
Hi Marcus, Your commit a504c004bf10555e5ea67ec89fe7bf6f00fe4622 broke S3 functionality. With S3 as secondary storage, system vm cannot be started. Since for S3, copy template to primary will be from an ImageCache store. Your following line of code : if (srcData.getObjectType() == DataObj