RE: Review request for storage motion on xenserver

2013-04-11 Thread Devdeep Singh
> -Original Message- > From: Devdeep Singh [mailto:devdeep.si...@citrix.com] > Sent: Friday, April 05, 2013 3:37 PM > To: dev@cloudstack.apache.org > Subject: RE: Review request for storage motion on xenserver > > Hi Edison, > > Thanks a lot for looking at the changes. I am

RE: Review request for storage motion on xenserver

2013-04-05 Thread Devdeep Singh
com] > Sent: Thursday, April 04, 2013 3:21 AM > To: dev@cloudstack.apache.org > Subject: RE: Review request for storage motion on xenserver > > Sorry for the late. Following is my comments on storage motion: > 1. We shouldn't touch volume state in virutalmachinemanager. I sp

RE: Review request for storage motion on xenserver

2013-04-03 Thread Edison Su
ay, March 29, 2013 8:21 AM > To: dev@cloudstack.apache.org > Subject: Review request for storage motion on xenserver > > I have put the feature proposed [1] and developed in the feature branch [2] > up for review. Code for this feature conforms to what was proposed in FS [3]. > The

Review request for storage motion on xenserver

2013-03-29 Thread Devdeep Singh
I have put the feature proposed [1] and developed in the feature branch [2] up for review. Code for this feature conforms to what was proposed in FS [3]. The patch available at [4]. It includes marvin tests and unit tests for verifying the functionality. Please take a look at it and let me know