Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-13 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review72352 --- Ship it! ada8cdce7009e41ddf37348cfac2d4f79592379e master - Srikant

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-11 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 11, 2015, 9:30 a.m.) Review request for cloudstack and Srikantesw

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-08 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 9, 2015, 5:38 a.m.) Review request for cloudstack and Srikanteswa

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-08 Thread Ashutosh Kelkar
> On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 911 > > > > > > dint get the need or use of this validation ... Will add check for equality here as the usage

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-08 Thread Ashutosh Kelkar
> On Feb. 5, 2015, 12:19 p.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 1394 > > > > > > not the right way for calculting usage of bytes send and received . We > > measure byte sen

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-08 Thread Ashutosh Kelkar
> On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 2509 > > > > > > not te right candidate for automation as we need to wt for 60 mins > > before usage records

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-08 Thread Ashutosh Kelkar
> On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 998 > > > > > > i dont think these two fileds templtat.id and record.usageid are same It's as mentioned here

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-08 Thread Ashutosh Kelkar
> On Feb. 4, 2015, 10:52 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 473 > > > > > > veirfy no further usage for this deleted template and iso is generated > > in next aggregatio

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-08 Thread Ashutosh Kelkar
> On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 2030 > > > > > > this is PF rule usage (type 12) i dont see usage type 12 created in > > this test case. NAT

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-06 Thread shweta agarwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71381 --- test/integration/testpaths/testpath_usage.py

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-05 Thread shweta agarwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71202 --- test/integration/testpaths/testpath_usage.py

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-05 Thread shweta agarwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71192 --- test/integration/testpaths/testpath_usage.py

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-05 Thread shweta agarwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71185 --- test/integration/testpaths/testpath_usage.py

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-05 Thread Ashutosh Kelkar
> On Feb. 5, 2015, 8:55 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 455 > > > > > > yes there will be . allocation time starts as soon as resources are > > allocated ..i.e vm com

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-05 Thread Ashutosh Kelkar
> On Feb. 5, 2015, 8:55 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 774 > > > > > > I cant make out how and what are you trying to veirfy in such type of > > assert . > > >

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-05 Thread shweta agarwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71180 --- test/integration/testpaths/testpath_usage.py

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-04 Thread Ashutosh Kelkar
> On Feb. 4, 2015, 9:33 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 455 > > > > > > we need to have usage for VM allocation type as well. > > > > and need to check that

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-04 Thread shweta agarwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review70945 --- test/integration/testpaths/testpath_usage.py

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-04 Thread shweta agarwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review70936 --- test/integration/testpaths/testpath_usage.py

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-04 Thread Ashutosh Kelkar
> On Feb. 4, 2015, 8:46 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 289 > > > > > > when uage server is not installed follwoing is the output > > > > service cloudstack-

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-04 Thread shweta agarwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review70929 --- test/integration/testpaths/testpath_usage.py

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-03 Thread Ashutosh Kelkar
> On Feb. 3, 2015, 10:41 a.m., shweta agarwal wrote: > > test/integration/testpaths/testpath_usage.py, line 141 > > > > > > why are we setting these value in seconds ? by default this config > > value is required in m

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-03 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 3, 2015, 12:24 p.m.) Review request for cloudstack and Srikantesw

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-02-03 Thread shweta agarwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review70731 --- test/integration/testpaths/testpath_usage.py

Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2015-01-30 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Jan. 30, 2015, 4:29 p.m.) Review request for cloudstack and Srikantesw

Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path

2014-11-13 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-79