Re: Review Request 26035: CLOUDSTACK-7633: fix "Provides" in most LSB headers

2014-10-09 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/#review55966 --- Ship it! 1ede3eeacb2e78a34d43003c12ff060b3aafeb21 - daan Hoogland

Re: Review Request 26035: CLOUDSTACK-7633: fix "Provides" in most LSB headers

2014-10-08 Thread Vincent Bernat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/ --- (Updated Oct. 8, 2014, 10:47 a.m.) Review request for cloudstack and daan Hoogl

Re: Review Request 26035: CLOUDSTACK-7633: fix "Provides" in most LSB headers

2014-09-25 Thread Rohit Yadav
> On Sept. 25, 2014, 2:55 p.m., Rohit Yadav wrote: > > Ship It! Merged on 4.3: 08cb7ef7fa0417ea1d9799a0757f459abc5a9883 Merged on master: 2401eb927bbda69f0376d1f34ef20631e1188540 Once your fix lands on 4.4, please close as submitted. - Rohit -

Re: Review Request 26035: CLOUDSTACK-7633: fix "Provides" in most LSB headers

2014-09-25 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/#review54539 --- Thanks for your quick fix, it's more consistent with the cloudstack-

Re: Review Request 26035: CLOUDSTACK-7633: fix "Provides" in most LSB headers

2014-09-25 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/#review54540 --- Ship it! Ship It! - Rohit Yadav On Sept. 25, 2014, 2:31 p.m., Vi

Re: Review Request 26035: CLOUDSTACK-7633: fix "Provides" in most LSB headers

2014-09-25 Thread Vincent Bernat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/ --- (Updated Sept. 25, 2014, 2:31 p.m.) Review request for cloudstack. Bugs: CLOU

Re: Review Request 26035: CLOUDSTACK-7633: fix "Provides" in most LSB headers

2014-09-25 Thread Vincent Bernat
> On Sept. 25, 2014, 2:12 p.m., Rohit Yadav wrote: > > I think they all should start with a "cloudstack-", I'm not sure but does > > this cause any issue for you? And I think they would be applicable on > > master, 4.4 branches as well. No problem with them starting with cloudstack- instead. I

Re: Review Request 26035: CLOUDSTACK-7633: fix "Provides" in most LSB headers

2014-09-25 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/#review54536 --- I think they all should start with a "cloudstack-", I'm not sure but

Review Request 26035: CLOUDSTACK-7633: fix "Provides" in most LSB headers

2014-09-25 Thread Vincent Bernat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/ --- Review request for cloudstack. Bugs: CLOUDSTACK-7633 https://issues.apache.