RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-22 Thread Sudha Ponnaganti
, Santhosh From: Sudha Ponnaganti [sudha.ponnaga...@citrix.com] Sent: Monday, July 21, 2014 7:42 AM To: dev@cloudstack.apache.org Subject: RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) Hugo, I absolutely agree with you that te

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-22 Thread Santhosh Edukulla
Ponnaganti [sudha.ponnaga...@citrix.com] Sent: Monday, July 21, 2014 7:42 AM To: dev@cloudstack.apache.org Subject: RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) Hugo, I absolutely agree with you that tests should not be disabled and fixes

Re: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Hugo Trippaers
> /Sudha > > [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Development+Process > > > -Original Message- > From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers > Sent: Monday, July 21, 2014 3:32 AM > To: dev@cloudstack.apache.org > Subje

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Stephen Turner
:43 To: dev@cloudstack.apache.org Subject: RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) Hugo, I absolutely agree with you that tests should not be disabled and fixes should be made before check in. As per what Alex has mentioned in

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Sudha Ponnaganti
+Process -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Monday, July 21, 2014 3:32 AM To: dev@cloudstack.apache.org Subject: Re: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) Hey Sudha

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Stephen Turner
ar Cc: Gaurav Aradhye; Hugo Trippaers; cloudstack Subject: Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases > On July 21, 2014, 1:03 p.m., Hugo Trippaers wrote: > > Why would we want to disable test cases that fail? Doesn't this mean we > > need to fix somethin

Re: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Hugo Trippaers
4 3:22 AM > To: Gaurav Aradhye; Stephen Turner; Hugo Trippaers; dev@cloudstack.apache.org > Cc: Girish Shilamkar > Subject: RE: Disabling failed test cases (was RE: Review Request 23605: > CLOUDSTACK-7107: Disabling failed test cases) > > All, > > Alex, wanted to disable tes

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Sudha Ponnaganti
2014 3:22 AM To: Gaurav Aradhye; Stephen Turner; Hugo Trippaers; dev@cloudstack.apache.org Cc: Girish Shilamkar Subject: RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) All, Alex, wanted to disable test cases in between CI( continuous i

Re: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Hugo Trippaers
logeny.com] > Sent: Monday, July 21, 2014 5:40 AM > To: Stephen Turner; Hugo Trippaers; dev@cloudstack.apache.org; Santhosh > Edukulla > Cc: Girish Shilamkar > Subject: Re: Disabling failed test cases (was RE: Review Request 23605: > CLOUDSTACK-7107: Disabling failed test cases) &

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Santhosh Edukulla
Subject: Re: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) Hugo, Stephen, We have been following this practice as part of Continuous Integration changes as defined in doc [1]. I personally think that tagging test case with BugId is good i

Re: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Gaurav Aradhye
whether your quality is going up or down. > > -- > Stephen Turner > > > -Original Message- > From: Gaurav Aradhye [mailto:nore...@reviews.apache.org] On Behalf Of > Gaurav Aradhye > Sent: 21 July 2014 09:58 > To: Girish Shilamkar > Cc: Gaurav Aradhye; Hugo T

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Stephen Turner
s; cloudstack Subject: Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases > On July 21, 2014, 1:03 p.m., Hugo Trippaers wrote: > > Why would we want to disable test cases that fail? Doesn't this mean we > > need to fix something else so they don't fail

Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases

2014-07-21 Thread Hugo Trippaers
Hey Gaurav, That doesn’t make a lot of sense to me. If the test sequence fails because of a bug it should keep failing until the bug is resolved, otherwise the tests will report that the situation is OK while in all reality it is not. These test should be in indication that Apache CloudStack is

Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases

2014-07-21 Thread Gaurav Aradhye
> On July 21, 2014, 1:03 p.m., Hugo Trippaers wrote: > > Why would we want to disable test cases that fail? Doesn't this mean we > > need to fix something else so they don't fail anymore? Hi Hugo, Whenever we found a test case failing, we create bug for that, may it be a test script issue or

Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases

2014-07-21 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23605/#review48204 --- Why would we want to disable test cases that fail? Doesn't this mean

Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases

2014-07-20 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23605/#review48203 --- Commit 43dffaad5fd197c87a8dab087066f677a095dee7 in cloudstack's bran

Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases

2014-07-17 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23605/#review47990 --- Commit 186606a0bf82402e7755cd7998f133023cc96c6c in cloudstack's bran

Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases

2014-07-17 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23605/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7074 and C