Re: Review Request 22093: VPC's VR missing public NIC eth1

Seems like I'm going to keep my eyes on issues...for now. Thanks Sent from Google Nexus 4 On Jun 7, 2014 6:02 PM, "Daan Hoogland" wrote: > Andrija, > > Please test upgrades if you can do them in lab envs. If not. just keep > reporting on issues as you encounter them. If you are skilled at java >

Re: Review Request 22093: VPC's VR missing public NIC eth1

Andrija, Please test upgrades if you can do them in lab envs. If not. just keep reporting on issues as you encounter them. If you are skilled at java you could isolate the upgrade step from the code in 4.4 resulting of the patch and run it against your branch. You would need to feel very comfortab

Re: Review Request 22093: VPC's VR missing public NIC eth1

Hi Daan, any help needed by me, regarding testing ? Did not catch these automated emails... Thanks, Andrija On 7 June 2014 10:23, daan Hoogland wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews

Re: Review Request 22093: VPC's VR missing public NIC eth1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22093/ --- (Updated June 7, 2014, 8:23 a.m.) Review request for cloudstack and Marcus Sore

Re: Review Request 22093: VPC's VR missing public NIC eth1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22093/ --- (Updated June 7, 2014, 8:23 a.m.) Review request for cloudstack and Marcus Sore

Re: Review Request 22093: VPC's VR missing public NIC eth1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22093/ --- (Updated June 7, 2014, 8:23 a.m.) Review request for cloudstack and Marcus Sore

Re: Review Request 22093: VPC's VR missing public NIC eth1

> On June 2, 2014, 8:32 a.m., Joris van Lieshout wrote: > > Another issue might be that new entries (we see this on ACS 4.3 with > > XenServer) are created without vlan:// > > The name of the field is vlan_id and not BroadcastURI so keeping it an > > integer only would make more sense to me. An

Re: Review Request 22093: VPC's VR missing public NIC eth1

> On June 2, 2014, 8:52 a.m., Koushik Das wrote: > > If someone is already on 4.3, is this fix not applicable? Shouldn't this go > > to 4.3-4.4 upgrade? yes, will do, I was wondering on this. It is a repeatable conversion so it can go in 4.3.0 to 4.3.1 and in 4.3 to 4.4 as well - daan

Re: Review Request 22093: VPC's VR missing public NIC eth1

> On June 2, 2014, 8:37 a.m., Erik Weber wrote: > > engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java, line 368 > > > > > > There's a typo in the where clause. vland_id should be vlan_id thanks, will fix

Re: Review Request 22093: VPC's VR missing public NIC eth1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22093/#review44482 --- If someone is already on 4.3, is this fix not applicable? Shouldn't

Re: Review Request 22093: VPC's VR missing public NIC eth1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22093/#review44481 --- engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java

Re: Review Request 22093: VPC's VR missing public NIC eth1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22093/#review44480 --- Another issue might be that new entries (we see this on ACS 4.3 with

Re: Review Request 22093: VPC's VR missing public NIC eth1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22093/#review44479 --- The issue I see with this fix is that it also applies to other hypve

Re: Review Request 22093: VPC's VR missing public NIC eth1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22093/ --- (Updated May 30, 2014, 9 p.m.) Review request for cloudstack and Marcus Sorense

Review Request 22093: VPC's VR missing public NIC eth1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22093/ --- Review request for cloudstack and Marcus Sorensen. Repository: cloudstack-git