---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/#review39882
---
Ship it!
master ecc71518a9a9fe1d7078a90dcbb4bbcc9bc2ca61
4.4 68c80e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/#review39881
---
Commit ecc71518a9a9fe1d7078a90dcbb4bbcc9bc2ca61 in cloudstack's bran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/#review39880
---
Commit 68c80e28c09a9459e3cf1c79f45718fb3b3678c7 in cloudstack's bran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/
---
(Updated April 9, 2014, 12:28 p.m.)
Review request for cloudstack, Jayapal Redd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/
---
(Updated April 9, 2014, 12:28 p.m.)
Review request for cloudstack, Jayapal Redd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/
---
(Updated April 9, 2014, 6:24 a.m.)
Review request for cloudstack, Jayapal Reddy
> On March 24, 2014, 10:03 p.m., Alena Prokharchyk wrote:
> > Also if you are hardcoding the state to search by, to Running in your
> > method, there is no need to define it in the method signature:
> >
> > public List listByRunningStateAndManagementServer(State
> > state, long mgmtSrvrId) {
> On March 24, 2014, 9:56 p.m., Alena Prokharchyk wrote:
> > DomainRouterDaoImpl.java
> >
> > Why do you iterate through VRs set twice? That doesn't seem right to me.
> > Why don't you just return original routerIds set?
> >
> >
> > public List listByRunningStateAndManagementServer(State
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/
---
(Updated March 25, 2014, 6:24 a.m.)
Review request for cloudstack, Jayapal Redd
> On March 24, 2014, 9:56 p.m., Alena Prokharchyk wrote:
> > DomainRouterDaoImpl.java
> >
> > Why do you iterate through VRs set twice? That doesn't seem right to me.
> > Why don't you just return original routerIds set?
> >
> >
> > public List listByRunningStateAndManagementServer(State
> >
> On March 24, 2014, 10:03 p.m., Alena Prokharchyk wrote:
> > Also if you are hardcoding the state to search by, to Running in your
> > method, there is no need to define it in the method signature:
> >
> > public List listByRunningStateAndManagementServer(State
> > state, long mgmtSrvrId) {
- Harikrishna
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/#review38374
---
On March 24, 2014, 2:17 p.m., Harikrishna Patnala w
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/#review38375
---
Also if you are hardcoding the state to search by, to Running in you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/#review38374
---
DomainRouterDaoImpl.java
Why do you iterate through VRs set twice?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/
---
(Updated March 24, 2014, 2:17 p.m.)
Review request for cloudstack, Jayapal Redd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19578/
---
Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Sheng Yang.
Bug
16 matches
Mail list logo
