Re: Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-10 Thread Suresh Balineni
esh Balineni mailto:sbalin...@service.juniper.net>>, cloudstack mailto:dev@cloudstack.apache.org>>, Sheng Yang mailto:sh...@yasker.org>> Subject: Re: Review Request 16642: Contrail plguin fixes for CS 4.3 This is an automatically generated e-mail. To reply, visit: https://reviews.apac

Re: Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-10 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16642/#review31576 --- Ship it! Looks good now. Applied to 4.3 branch. - Sheng Yang On

Re: Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-10 Thread Suresh Balineni
> On Jan. 11, 2014, 12:53 a.m., Sheng Yang wrote: > > The attached file is also the same file like others. > > > > Please check your uploaded file. Hi Sheng, Its my mistake. Please use the just updated file. - Suresh --- This is an au

Re: Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-10 Thread Suresh Balineni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16642/ --- (Updated Jan. 11, 2014, 12:59 a.m.) Review request for cloudstack. Repository

Re: Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-10 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16642/#review31568 --- The attached file is also the same file like others. Please check y

Re: Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-10 Thread Sheng Yang
> On Jan. 11, 2014, 12:03 a.m., Sheng Yang wrote: > > Ship It! > > Sheng Yang wrote: > Applied to 4.3 branch. Thanks. > > But need a patch for master branch as well. > > Sheng Yang wrote: > Reverted from 4.3 branch. > > It cannot compile. > > Suresh Balineni wrote: >

Re: Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-10 Thread Suresh Balineni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16642/ --- (Updated Jan. 11, 2014, 12:51 a.m.) Review request for cloudstack. Changes --

Re: Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-10 Thread Suresh Balineni
> On Jan. 11, 2014, 12:03 a.m., Sheng Yang wrote: > > Ship It! > > Sheng Yang wrote: > Applied to 4.3 branch. Thanks. > > But need a patch for master branch as well. > > Sheng Yang wrote: > Reverted from 4.3 branch. > > It cannot compile. Hi Sheng, I submitted revisi

Re: Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-10 Thread Suresh Balineni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16642/ --- (Updated Jan. 11, 2014, 12:44 a.m.) Review request for cloudstack. Repository

Re: Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-10 Thread Sheng Yang
> On Jan. 11, 2014, 12:03 a.m., Sheng Yang wrote: > > Ship It! > > Sheng Yang wrote: > Applied to 4.3 branch. Thanks. > > But need a patch for master branch as well. Reverted from 4.3 branch. It cannot compile. - Sheng --

Re: Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-10 Thread Sheng Yang
> On Jan. 11, 2014, 12:03 a.m., Sheng Yang wrote: > > Ship It! Applied to 4.3 branch. Thanks. But need a patch for master branch as well. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-10 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16642/#review31556 --- Ship it! Ship It! - Sheng Yang On Jan. 7, 2014, 11:40 p.m., Sure

Re: Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-07 Thread Suresh Balineni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16642/ --- (Updated Jan. 7, 2014, 11:40 p.m.) Review request for cloudstack. Repository:

Review Request 16642: Contrail plguin fixes for CS 4.3

2014-01-04 Thread Suresh Balineni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16642/ --- Review request for cloudstack. Repository: cloudstack-git Description ---