Re: Review Request 14990: added formatter setting xml file for eclipse

2013-10-29 Thread daan Hoogland
> On Oct. 29, 2013, 1:21 p.m., daan Hoogland wrote: > > Ship It! 4c6add84d866babcbc312ae441f615870087ac3d - daan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14990/#review27672 ---

Re: Review Request 14990: added formatter setting xml file for eclipse

2013-10-29 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14990/#review27672 --- Ship it! Ship It! - daan Hoogland On Oct. 28, 2013, 2:25 p.m., R

Re: Review Request 14990: added formatter setting xml file for eclipse

2013-10-28 Thread Rajani Karuturi
> On Oct. 28, 2013, 1:52 p.m., daan Hoogland wrote: > > If this work the patch should include removing the epf file. It makes no > > sense having both around, unless... > > Is this xml format compatible with all eclipse versions? Did you test it > > with any? > > daan Hoogland wrote: > i m

Re: Review Request 14990: added formatter setting xml file for eclipse

2013-10-28 Thread Rajani Karuturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14990/ --- (Updated Oct. 28, 2013, 2:25 p.m.) Review request for cloudstack, daan Hoogland

Re: Review Request 14990: added formatter setting xml file for eclipse

2013-10-28 Thread daan Hoogland
> On Oct. 28, 2013, 1:52 p.m., daan Hoogland wrote: > > If this work the patch should include removing the epf file. It makes no > > sense having both around, unless... > > Is this xml format compatible with all eclipse versions? Did you test it > > with any? i mean which ones? - daan

Re: Review Request 14990: added formatter setting xml file for eclipse

2013-10-28 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14990/#review27610 --- If this work the patch should include removing the epf file. It make

Review Request 14990: added formatter setting xml file for eclipse

2013-10-28 Thread Rajani Karuturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14990/ --- Review request for cloudstack, daan Hoogland and Prasanna Santhanam. Repository