Re: Review Request 14648: Added few changes related to 4870

2013-11-08 Thread Girish Shilamkar
> On Nov. 8, 2013, 9:15 a.m., Girish Shilamkar wrote: > > 4.2: fba874120bb40ddeceacbc7ef51217f34d3749de > > Sebastien Goasguen wrote: > if these patches apply to master, can you make sure to also apply to > master at the same time. thanks They were already applied to master but missing in

Re: Review Request 14648: Added few changes related to 4870

2013-11-08 Thread Sebastien Goasguen
> On Nov. 8, 2013, 9:15 a.m., Girish Shilamkar wrote: > > 4.2: fba874120bb40ddeceacbc7ef51217f34d3749de if these patches apply to master, can you make sure to also apply to master at the same time. thanks - Sebastien --- This is an aut

Re: Review Request 14648: Added few changes related to 4870

2013-11-08 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14648/#review28520 --- 4.2: fba874120bb40ddeceacbc7ef51217f34d3749de - Girish Shilamkar

Re: Review Request 14648: Added few changes related to 4870

2013-10-23 Thread Santhosh Edukulla
> On Oct. 22, 2013, 6:37 a.m., Prasanna Santhanam wrote: > > This looks fine except pep8 is broken in a few places. Can you please run > > pep8 *.py in tools/marvin/marvin to ensure the formatting is maintained? > > Please upload the patch that corrects these issues. The changes for this went

Re: Review Request 14648: Added few changes related to 4870

2013-10-21 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14648/#review27279 --- This looks fine except pep8 is broken in a few places. Can you pleas

Re: Review Request 14648: Added few changes related to 4870

2013-10-15 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14648/ --- (Updated Oct. 15, 2013, 12:10 p.m.) Review request for cloudstack and Prasanna