Re: Review Request 14556: CLOUDSTACK-4766: Add timeout if vm does not reach running state

2013-10-17 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14556/#review27117 --- Commit 9cc557509265d8faacca134e8bfeb3a31ddbeb31 in branch refs/heads

Re: Review Request 14556: CLOUDSTACK-4766: Add timeout if vm does not reach running state

2013-10-17 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14556/#review27116 --- Commit e3bcdc16a11d7452b5bf6ce5e5993dcd008526a6 in branch refs/heads

Re: Review Request 14556: CLOUDSTACK-4766: Add timeout if vm does not reach running state

2013-10-17 Thread sanjeev n
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14556/#review27113 --- Ship it! Patch is good to go. - sanjeev n On Oct. 9, 2013, 9:50

Re: Review Request 14556: CLOUDSTACK-4766: Add timeout if vm does not reach running state

2013-10-09 Thread Girish Shilamkar
> On Oct. 9, 2013, 11:03 a.m., sanjeev n wrote: > > Patch looks good. However still test is failing. Is it a product issue? The problem was if vm did not come up, the test went into infinite loop. Now it times out gracefully and therefore we see the failure, which is the expected output. -

Re: Review Request 14556: CLOUDSTACK-4766: Add timeout if vm does not reach running state

2013-10-09 Thread sanjeev n
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14556/#review26816 --- Patch looks good. However still test is failing. Is it a product iss

Review Request 14556: CLOUDSTACK-4766: Add timeout if vm does not reach running state

2013-10-09 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14556/ --- Review request for cloudstack, sanjeev n and venkata swamy babu budumuru. Bugs