Re: Review Request 14190: Switch to setter injection for extensibility

2013-09-30 Thread Darren Shepherd
> On Sept. 30, 2013, 9:52 p.m., Kelven Yang wrote: > > Ship It! master: efbfae723ec5583378cb90c54fc63b6975c7fc24 - Darren --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14190/#review26521 --

Re: Review Request 14190: Switch to setter injection for extensibility

2013-09-30 Thread Kelven Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14190/#review26521 --- Ship it! Ship It! - Kelven Yang On Sept. 18, 2013, 3:49 p.m., Da

Re: Review Request 14190: Switch to setter injection for extensibility

2013-09-30 Thread Darren Shepherd
> On Sept. 30, 2013, 4:22 a.m., Kelven Yang wrote: > > Daren, > > > > when getGuru() is call in a non-initial phase, it may be involved with > > multi-threaded context, I suggest to make it thread-safe > > > > > > public HypervisorGuru getGuru(HypervisorType hypervisorType) { > > 58 >

Re: Review Request 14190: Switch to setter injection for extensibility

2013-09-29 Thread Kelven Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14190/#review26468 --- Daren, when getGuru() is call in a non-initial phase, it may be inv

Review Request 14190: Switch to setter injection for extensibility

2013-09-18 Thread Darren Shepherd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14190/ --- Review request for cloudstack, Alex Huang and Kelven Yang. Repository: cloudsta