Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-11-13 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/#review28811 --- Committed to 4.2, 4.3 and master. - Girish Shilamkar On Nov. 8, 2

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-11-12 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/#review28782 --- Ship it! Ship It! - Girish Shilamkar On Nov. 8, 2013, 1:48 p.m.,

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-11-08 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/ --- (Updated Nov. 8, 2013, 1:48 p.m.) Review request for cloudstack, Girish Shilamk

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-10-29 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/#review27758 --- patch failed to apply on 4.2 git apply vmvpc.patch error: patch

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-10-16 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/ --- (Updated Oct. 16, 2013, 2:09 p.m.) Review request for cloudstack, Girish Shilam

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-10-16 Thread Ashutosh Kelkar
> On Oct. 16, 2013, 1:53 p.m., suresh sadhu wrote: > > reviewed the code and added host tags in the code as per the review > > comments but when we ran the TestVMLifeCycleDiffHosts tests,it failed with > > Host.Update method is undefined in our environment.can you please rerun and > > confir

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-10-16 Thread suresh sadhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/#review27064 --- reviewed the code and added host tags in the code as per the revie

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-10-09 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/ --- (Updated Oct. 9, 2013, 11:28 a.m.) Review request for cloudstack, Girish Shilam

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-09-30 Thread Sheng Yang
> On Sept. 26, 2013, 1:30 a.m., Sheng Yang wrote: > > Please test it before submit. > > Ashutosh Kelkar wrote: > The tests have been tested and run correctly. There is a manual step > needed in setup for these tests - Adding host tags to the hosts which is why > the tests are skipped when

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-09-30 Thread Sheng Yang
> On Sept. 26, 2013, 1:30 a.m., Sheng Yang wrote: > > Please test it before submit. > > Ashutosh Kelkar wrote: > The tests have been tested and run correctly. There is a manual step > needed in setup for these tests - Adding host tags to the hosts which is why > the tests are skipped when

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-09-29 Thread Ashutosh Kelkar
> On Sept. 26, 2013, 1:30 a.m., Sheng Yang wrote: > > Please test it before submit. > > Ashutosh Kelkar wrote: > The tests have been tested and run correctly. There is a manual step > needed in setup for these tests - Adding host tags to the hosts which is why > the tests are skipped when

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-09-27 Thread Sheng Yang
> On Sept. 26, 2013, 1:30 a.m., Sheng Yang wrote: > > Please test it before submit. > > Ashutosh Kelkar wrote: > The tests have been tested and run correctly. There is a manual step > needed in setup for these tests - Adding host tags to the hosts which is why > the tests are skipped when

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-09-26 Thread Ashutosh Kelkar
> On Sept. 26, 2013, 1:30 a.m., Sheng Yang wrote: > > Please test it before submit. The tests have been tested and run correctly. There is a manual step needed in setup for these tests - Adding host tags to the hosts which is why the tests are skipped when committing. - Ashutosh --

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-09-25 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/#review26402 --- Please test it before submit. - Sheng Yang On Sept. 18, 2013, 2:2

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-09-18 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/ --- (Updated Sept. 18, 2013, 2:28 p.m.) Review request for cloudstack, Girish Shila

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-09-09 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/ --- (Updated Sept. 10, 2013, 5:53 a.m.) Review request for cloudstack, Girish Shila