Re: Review Request 13877: CIFS Secondary Storage

2013-09-11 Thread Devdeep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13877/#review26038 --- Ship it! pushed in commit e958f22ff34e089b4214ee5be68688540db5291a

Re: Review Request 13877: CIFS Secondary Storage

2013-09-11 Thread Devdeep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13877/#review26036 --- Can you resubmit the patch? I am not able to apply the patch on the

Re: Review Request 13877: CIFS Secondary Storage

2013-09-10 Thread Rajesh Battala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13877/#review26034 --- Ship it! Ship It! - Rajesh Battala On Aug. 28, 2013, 8:58 p.m.,

Re: Review Request 13877: CIFS Secondary Storage

2013-09-10 Thread Rajesh Battala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13877/#review26035 --- Ship it! Looks good for me. - Rajesh Battala On Aug. 28, 2013, 8

Re: Review Request 13877: CIFS Secondary Storage

2013-09-05 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13877/#review25940 --- Ok for me. - edison su On Aug. 28, 2013, 8:58 p.m., Donal Laffert

Re: Review Request 13877: CIFS Secondary Storage

2013-08-28 Thread Donal Lafferty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13877/ --- (Updated Aug. 28, 2013, 8:58 p.m.) Review request for cloudstack, Chiradeep Vit

Re: Review Request 13877: CIFS Secondary Storage

2013-08-28 Thread Donal Lafferty
> On Aug. 28, 2013, 6:52 p.m., Chiradeep Vittal wrote: > > engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java, > > line 152 > > > > > > No idea why this is here. Can you

Re: Review Request 13877: CIFS Secondary Storage

2013-08-28 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13877/#review25675 --- engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/

Review Request 13877: CIFS Secondary Storage

2013-08-27 Thread Donal Lafferty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13877/ --- Review request for cloudstack, Chiradeep Vittal and Devdeep Singh. Repository: