Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

2013-08-05 Thread Sheng Yang
> On Aug. 5, 2013, 6:19 p.m., Sheng Yang wrote: > > Ship It! Pushed to 4.2 and MASTER. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13240/#review24654 -

Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

2013-08-05 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13240/#review24654 --- Ship it! Ship It! - Sheng Yang On Aug. 5, 2013, 9:59 a.m., daan

Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

2013-08-05 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13240/ --- (Updated Aug. 5, 2013, 9:59 a.m.) Review request for cloudstack, Chiradeep Vitt

Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

2013-08-05 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13240/ --- (Updated Aug. 5, 2013, 9:36 a.m.) Review request for cloudstack and Sheng Yang.

Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

2013-08-03 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13240/ --- (Updated Aug. 3, 2013, 9:54 a.m.) Review request for cloudstack. Changes

Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

2013-08-02 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13240/#review24576 --- server/src/com/cloud/network/NetworkServiceImpl.java

Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

2013-08-02 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13240/#review24529 --- Review 13240 failed the build test : FAILURE The url of build clouds

Review Request 13240: dealt with some warnings in NetworkServiceImpl

2013-08-02 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13240/ --- Review request for cloudstack. Repository: cloudstack-git Description ---