Re: Review Request 12976: Remove duplicate row from guest_os table

2013-08-02 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12976/#review24590 --- Ship it! Ship It! - Alena Prokharchyk On Aug. 2, 2013, 10:43 p.m

Re: Review Request 12976: Remove duplicate row from guest_os table

2013-08-02 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12976/ --- (Updated Aug. 2, 2013, 10:43 p.m.) Review request for cloudstack, Alena Prokhar

Re: Review Request 12976: Remove duplicate row from guest_os table

2013-08-02 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12976/#review24559 --- The fix is good, but the patch failed to apply: alena@macbookpro: [

Re: Review Request 12976: Remove duplicate row from guest_os table

2013-07-27 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12976/ --- (Updated July 27, 2013, 7:22 p.m.) Review request for cloudstack, Alena Prokhar

Re: Review Request 12976: Remove duplicate row from guest_os table

2013-07-27 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12976/ --- (Updated July 27, 2013, 7:21 p.m.) Review request for cloudstack, Alena Prokhar

Re: Review Request 12976: Remove duplicate row from guest_os table

2013-07-27 Thread Amogh Vasekar
> On July 26, 2013, 11:51 p.m., Alena Prokharchyk wrote: > > We can't just remove the row w/o making sure its not being referenced by > > existing resources. So putting "DELETE IGNORE FROM `cloud`.`guest_os` where > > id=206" is not enough. You can go 2 ways: > > > > #1 - don't insert the reco

Re: Review Request 12976: Remove duplicate row from guest_os table

2013-07-26 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12976/#review23996 --- We can't just remove the row w/o making sure its not being reference

Re: Review Request 12976: Remove duplicate row from guest_os table

2013-07-26 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12976/#review23964 --- Review 12976 PASSED the build test The url of build cloudstack-maste

Review Request 12976: Remove duplicate row from guest_os table

2013-07-26 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12976/ --- Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra Bha