Re: Review Request 12941: [GSoC] refactor gre controller

2013-08-12 Thread Hugo Trippaers
> On Aug. 12, 2013, 11:30 a.m., Hugo Trippaers wrote: > > Ship It! Targeted to the sdnextensions branch. Commit id : 0d6125f36449b1fcbbc5d296496c4a01f2208fc4 - Hugo --- This is an automatically generated e-mail. To reply, visit: https:

Re: Review Request 12941: [GSoC] refactor gre controller

2013-08-12 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12941/#review24990 --- Ship it! Ship It! - Hugo Trippaers On Aug. 1, 2013, 1:41 a.m., t

Re: Review Request 12941: [GSoC] refactor gre controller

2013-07-31 Thread tuna
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12941/ --- (Updated Aug. 1, 2013, 1:41 a.m.) Review request for cloudstack, Sebastien Goas

Re: Review Request 12941: [GSoC] refactor gre controller

2013-07-29 Thread Nguyen Anh Tu
Hi Hugo, Do you want to keep sdn.ovs.controller param in configuration? I have already replaced it by checking whether physical-network-isolation-type is GRE or not. But I just see two threads using this param and I don't know what they run for. It's placed at configure() method of OvsTunnelManage

Re: Review Request 12941: [GSoC] refactor gre controller

2013-07-29 Thread Nguyen Anh Tu
Hi, Following Hugo's review, I already changed and created an updated patch. Now I'm re-deploying system for final-testing before submitting the update patch. But getting an error on creating systemvm. Let me fix them first, make final-test and then submit the updated patch. Cheers, 2013/7/26 N

Re: Review Request 12941: [GSoC] refactor gre controller

2013-07-25 Thread Nguyen Anh Tu
Hi Hugo, I saw your review. But I have to concentrate to finish my report today. Will comeback to review tomorrow :-) 2013/7/25 Jenkins Cloudstack.org >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12941/ > > Review 12941 failed the build test :

Re: Review Request 12941: [GSoC] refactor gre controller

2013-07-25 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12941/#review23833 --- Review 12941 failed the build test : FAILURE The url of build clouds

Re: Review Request 12941: [GSoC] refactor gre controller

2013-07-25 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12941/#review23827 --- Heya, There is some feedback from reading the diffs. In general the

Review Request 12941: [GSoC] refactor gre controller

2013-07-25 Thread tuna
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12941/ --- Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Repositor