Re: Review Request 12752: Async commands can inject the job id

So all that's left on this is a use case writeup and the test, right? On Fri, Jul 19, 2013 at 11:54 AM, Ryan Dietrich wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12752/ > Review request for cloudstack and Marcus Sorensen. > By Ryan Die

Re: Review Request 12752: Async commands can inject the job id

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12752/ --- (Updated July 19, 2013, 5:54 p.m.) Review request for cloudstack and Marcus Sor

Re: Review Request 12752: Async commands can inject the job id

This is maybe a tangent, but does cloudstack check for uniqueness when generating a UUID? I haven't seen it anywhere, I've always seen it do UUID.randomUUID() and no checking. However, I guess the point is that CS is in control of making sure it's randomly generated, with this patch CS could be fed

Re: Review Request 12752: Async commands can inject the job id

Ryan, You should open a bug and add details on what the use case you are trying to solve. Since CloudStack is not in control of UUID generation, you should at least check that uniqueness of passed in UUID. Also please introduce a new smoke test for 'injected job id' instead of piggy backing the t

Re: Review Request 12752: Async commands can inject the job id

> On July 18, 2013, 11:34 p.m., Marcus Sorensen wrote: > > server/src/com/cloud/async/AsyncJobVO.java, line 141 > > > > > > I'm not immediately certain why this was pulled out. Nothing is using it. I did a scan to se

Re: Review Request 12752: Async commands can inject the job id

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12752/#review23457 --- api/src/org/apache/cloudstack/api/BaseAsyncCmd.java

Review Request 12752: Async commands can inject the job id

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12752/ --- Review request for cloudstack and Marcus Sorensen. Repository: cloudstack-git