Hi,
Adding Daan's reply - I sent to the wrong dev@ first time around, so the
reply went astray:
> On Tue, Aug 6, 2013 at 10:30 AM, Dave Cahill wrote:
> > I'm pretty sure the current scheme check is invalid given the URI spec,
but
> > definitely
> > shout if I'm off base.
>
> You are not 'way' of
Hi Daan / Alex,
Sorry I missed this change at the time, but it looks problematic to me.
The code is trying to check for a scheme part in the incoming value, and
doesn't add
a scheme if value already has one. Therefore, if the scheme check has a
false positive
(it thinks the value has a scheme, bu
x Huang
Cc: cloudstack
Subject: RE: Review Request 12685: CLOUDSTACK-1532 added utility functions to
scan URIs
Ok,
I don't like changing this enum. I'd rather throw it out and start over but you
are answering the question by sharing your views on school of programming, i
think. BroadcastDo
; ** **
>
> *From:* Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> *Sent:* Sunday, July 21, 2013 8:37 AM
> *To:* Alex Huang
> *Cc:* Hugo Trippaers; cloudstack
> *Subject:* Re: Review Request 12685: CLOUDSTACK-1532 added utility
> functions to scan URIs
>
> ** **
>
in this school. I think it should ask the question "should it be
undecided".
--Alex
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Sunday, July 21, 2013 8:37 AM
To: Alex Huang
Cc: Hugo Trippaers; cloudstack
Subject: Re: Review Request 12685: CLOUDSTACK-1532 added ut
--Alex
>
>
>
> *From:* Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> *Sent:* Saturday, July 20, 2013 3:25 AM
> *To:* Alex Huang
> *Cc:* Hugo Trippaers; cloudstack
> *Subject:* Re: Review Request 12685: CLOUDSTACK-1532 added utility
> functions to scan URIs
&
Daan,
I'm not sure I understand what you're saying here.
--Alex
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Sunday, July 21, 2013 4:23 AM
To: Alex Huang
Cc: Hugo Trippaers; cloudstack
Subject: Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to
scan
/confluence/display/CLOUDSTACK/Exceptions+and+logging
>
>
> ** **
>
> --Alex
>
> ** **
>
> *From:* Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> *Sent:* Saturday, July 20, 2013 3:25 AM
> *To:* Alex Huang
> *Cc:* Hugo Trippaers; cloudstack
> *Subject:
: Review Request 12685: CLOUDSTACK-1532 added utility functions to
scan URIs
Alex,
it falls through to 'UnDecided' if not known. Do you mean it should throw
something? or maybe add an extra 'UnDefined'?
On Fri, Jul 19, 2013 at 5:31 PM, Alex Huang
mailto:alex.hu...@citrix.com
Alex,
it falls through to 'UnDecided' if not known. Do you mean it should throw
something? or maybe add an extra 'UnDefined'?
On Fri, Jul 19, 2013 at 5:31 PM, Alex Huang wrote:
>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12685/
>
> Ship it!
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12685/#review23515
---
Ship it!
master: 2d4464d
One review comment is if you are checking
> On July 19, 2013, 9:41 a.m., Wido den Hollander wrote:
> > It seems good to me? Code-wise I can't find anything that isn't right.
> >
> > I see that Spark404 is also mentioned here, did he get a chance to look at
> > this yet?
Yeah, i'm ok with this.
I'm actually abusing this patch to test
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12685/#review23493
---
It seems good to me? Code-wise I can't find anything that isn't righ
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12685/
---
Review request for cloudstack and Hugo Trippaers.
Bugs: CLOUDSTACK-1532
Repos
14 matches
Mail list logo
