Re: Review Request 12134: removed txn attribute from DB annotation

2013-10-04 Thread Darren Shepherd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12134/#review26678 --- Ship it! master: bd8536739c012e1025d35271ce82dbc9e5e66a8d - Darren

Re: Review Request 12134: removed txn attribute from DB annotation

2013-09-04 Thread Kelven Yang
On 9/4/13 10:18 AM, "Darren Shepherd" wrote: >On 09/04/2013 10:04 AM, Alex Huang wrote: >> Kelven and Darren should review this. >> >> That attribute used to be always read to determine if a method should >>be intercepted at load time. My understanding is the switch to using >>spring as the in

RE: Review Request 12134: removed txn attribute from DB annotation

2013-09-04 Thread Alex Huang
From: Prasanna Santhanam [mailto:nore...@reviews.apache.org] On Behalf > Of Prasanna Santhanam > Sent: Wednesday, September 4, 2013 9:56 AM > To: Darren Shepherd; Alex Huang > Cc: Prasanna Santhanam; Laszlo Hornyak; cloudstack > Subject: Re: Review Request 12134: removed txn attribute

RE: Review Request 12134: removed txn attribute from DB annotation

2013-09-04 Thread Alex Huang
Shepherd; Alex Huang Cc: Prasanna Santhanam; Laszlo Hornyak; cloudstack Subject: Re: Review Request 12134: removed txn attribute from DB annotation This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12134/ Review request for cloudstack, Alex Huang and Darren

Re: Review Request 12134: removed txn attribute from DB annotation

2013-09-04 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12134/ --- (Updated Sept. 4, 2013, 4:55 p.m.) Review request for cloudstack, Alex Huang an

Re: Review Request 12134: removed txn attribute from DB annotation

2013-09-04 Thread Darren Shepherd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12134/#review25889 --- Ship it! Ship It: Not committed, Pending review from alexh - Darre

Re: Review Request 12134: removed txn attribute from DB annotation

2013-09-04 Thread Darren Shepherd
On 09/04/2013 10:04 AM, Alex Huang wrote: Kelven and Darren should review this. That attribute used to be always read to determine if a method should be intercepted at load time. My understanding is the switch to using spring as the injection mechanism caused this to be turned off and now eve

Re: Review Request 12134: removed txn attribute from DB annotation

2013-09-04 Thread Darren Shepherd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12134/#review25888 --- Ship it! Ship It! - Darren Shepherd On Sept. 4, 2013, 4:55 p.m.,

Re: Review Request 12134: removed txn attribute from DB annotation

2013-08-30 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12134/ --- (Updated Aug. 30, 2013, 4:23 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 12134: removed txn attribute from DB annotation

2013-08-29 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12134/#review25742 --- By now this patch is kind of outdated and needs an update, just wond

Review Request 12134: removed txn attribute from DB annotation

2013-06-27 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12134/ --- Review request for cloudstack. Repository: cloudstack-git Description ---