Re: Review Request: use commons-lang StringUtils

2013-06-17 Thread Chip Childers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11767/#review21998 --- Ship it! Applied to master: c88d8fb3a2f6c418c6c7af8ff702a93bcdb2d75

Re: Review Request: use commons-lang StringUtils

2013-06-15 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11767/ --- (Updated June 15, 2013, 4:32 p.m.) Review request for cloudstack. Changes ---

RE: Review Request: use commons-lang StringUtils

2013-06-11 Thread Alex Huang
Ok...please resubmit. --Alex > -Original Message- > From: Laszlo Hornyak [mailto:nore...@reviews.apache.org] On Behalf Of > Laszlo Hornyak > Sent: Tuesday, June 11, 2013 11:48 AM > To: cloudstack; Laszlo Hornyak; Alex Huang > Subject: Re: Review Request: use common

Re: Review Request: use commons-lang StringUtils

2013-06-11 Thread Laszlo Hornyak
> On June 10, 2013, 11:56 p.m., Alex Huang wrote: > > The patch did not apply cleanly. Please resubmit. Since you have to > > resubmit anyways, I think why not just change all of the code to use the > > commons.lang version. I see no point in keeping the method in StringUtils > > if it's re

Re: Review Request: use commons-lang StringUtils

2013-06-10 Thread Alex Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11767/#review21678 --- The patch did not apply cleanly. Please resubmit. Since you have t

Review Request: use commons-lang StringUtils

2013-06-09 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11767/ --- Review request for cloudstack. Description --- commons-lang is already a t