Re: Review Request: Fix command for executing injectkeys.sh

2013-04-15 Thread Hugo Trippaers
> On April 15, 2013, 6:43 p.m., Hugo Trippaers wrote: > > Ship It! Commit on master 794e653c1325f6ba78b700f62e75c5a7b502c4eb Thanks for fixing my bug ;-) - Hugo --- This is an automatically generated e-mail. To reply, visit: https://re

Re: Review Request: Fix command for executing injectkeys.sh

2013-04-15 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10437/#review19205 --- Ship it! Ship It! - Hugo Trippaers On April 12, 2013, 9:11 p.m.,

Re: Review Request: Fix command for executing injectkeys.sh

2013-04-15 Thread Chiradeep Vittal
Doesn't look like it On 4/15/13 10:07 AM, "Chip Childers" wrote: >Do I need a patch for this in 4.1? > >On Mon, Apr 15, 2013 at 05:02:07PM +, Chiradeep Vittal wrote: >> >> --- >> This is an automatically generated e-mail. To reply, vis

Re: Review Request: Fix command for executing injectkeys.sh

2013-04-15 Thread Phong Nguyen
No, only need for master. I just checked 4.1 and it does not have the changes from commit 5cd3608. On Mon, Apr 15, 2013 at 1:07 PM, Chip Childers wrote: > Do I need a patch for this in 4.1? > > On Mon, Apr 15, 2013 at 05:02:07PM +, Chiradeep Vittal wrote: > > > >

Re: Review Request: Fix command for executing injectkeys.sh

2013-04-15 Thread Chip Childers
Do I need a patch for this in 4.1? On Mon, Apr 15, 2013 at 05:02:07PM +, Chiradeep Vittal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10437/#review19193 > --

Re: Review Request: Fix command for executing injectkeys.sh

2013-04-15 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10437/#review19193 --- Ship it! Ship It! - Chiradeep Vittal On April 12, 2013, 9:11 p.m

Re: Review Request: Fix command for executing injectkeys.sh

2013-04-13 Thread Phong Nguyen
This fixes an bug introduced in that commit. I also want to point out that line 669 in ConfigurationServerImpl.java traps exceptions thrown in development mode, hence this bug would not have surfaced when ran in development mode. This 669 line appears to have been committed months ago, removing it

Re: Review Request: Fix command for executing injectkeys.sh

2013-04-12 Thread Chiradeep Vittal
Does this conflict with 5cd3608 Remove the chmod solution and replace with an explicit call to /bin/bash. This way the file will only need read permissions. On 4/12/13 2:11 PM, "Phong Nguyen" wrote: > >--- >This is an automatically genera

Review Request: Fix command for executing injectkeys.sh

2013-04-12 Thread Phong Nguyen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10437/ --- Review request for cloudstack and Hugo Trippaers. Description --- Manageme