Re: Review Request: Adding more Granular Global Parameters

2013-04-28 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10740/ --- (Updated April 29, 2013, 6:40 a.m.) Review request for cloudstack, Abhinandan P

Re: Review Request: Adding more Granular Global Parameters

2013-04-28 Thread Abhinandan Prateek
> On April 29, 2013, 6:22 a.m., Abhinandan Prateek wrote: > > Ship It! The patch does not apply please resubmit. - Abhinandan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10740/#review1984

Re: Review Request: Adding more Granular Global Parameters

2013-04-28 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10740/#review19847 --- Ship it! Ship It! - Abhinandan Prateek On April 26, 2013, 5:31 a

Re: Review Request: Adding more Granular Global Parameters

2013-04-28 Thread Harikrishna Patnala
> On April 28, 2013, 6:49 a.m., Nitin Mehta wrote: > > server/src/com/cloud/configuration/Config.java, line 56 > > > > > > Where is the actual change for this config in the code ? It should have > > been AlertManagerIm

Re: Review Request: Adding more Granular Global Parameters

2013-04-27 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10740/#review19830 --- server/src/com/cloud/configuration/Config.java

Re: Review Request: Adding more Granular Global Parameters

2013-04-25 Thread Prasanna Santhanam
On Fri, Apr 26, 2013 at 04:54:45AM -, Sateesh Chodapuneedi wrote: > api/src/com/cloud/configuration/ConfigurationService.java > > > Need to avoid * imports per coding guidelines. Likely coming from the IDE auto importing. I had to fix thi

Re: Review Request: Adding more Granular Global Parameters

2013-04-25 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10740/ --- (Updated April 26, 2013, 5:31 a.m.) Review request for cloudstack, Abhinandan P

Re: Review Request: Adding more Granular Global Parameters

2013-04-25 Thread Sateesh Chodapuneedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10740/#review19752 --- api/src/com/cloud/configuration/ConfigurationService.java

Re: Review Request: Adding more Granular Global Parameters

2013-04-25 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10740/ --- (Updated April 26, 2013, 4:33 a.m.) Review request for cloudstack, Abhinandan P

Re: Review Request: Adding more Granular Global Parameters

2013-04-25 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10740/ --- (Updated April 26, 2013, 3:37 a.m.) Review request for cloudstack, Abhinandan P

Re: Review Request: Adding more Granular Global Parameters

2013-04-25 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10740/#review19701 --- Can you resubmit the patch after changing scope_id/scope_name to zon

Review Request: Adding more Granular Global Parameters

2013-04-23 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10740/ --- Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Meht