Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Daan Hoogland
On Tue, Jul 7, 2015 at 1:37 PM, Rajani Karuturi wrote: > This not a good candidate for squashing/huge commit. > If a regression is found in any of the fixes, it will be easier to just > revert it than reverting all the 70 commits. > > ~Rajani Thanks Rajani, I allready made a booboo in the first

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Rajani Karuturi
This not a good candidate for squashing/huge commit. If a regression is found in any of the fixes, it will be easier to just revert it than reverting all the 70 commits. ~Rajani On Tue, Jul 7, 2015 at 3:47 PM, Rohit Yadav wrote: > > On 07-Jul-2015, at 3:40 pm, Daan Hoogland wrote: > > I will n

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Rohit Yadav
On 07-Jul-2015, at 3:40 pm, Daan Hoogland mailto:daan.hoogl...@gmail.com>> wrote: I will not do it in one commit, if we insist on a PR i will do 73 commits in one PR. Fine. Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 |

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Daan Hoogland
Sorre Sebastien, I will -1 squashing any other then typo or to and fro commits. On Tue, Jul 7, 2015 at 12:15 PM, sebgoa wrote: > > On Jul 7, 2015, at 12:10 PM, Daan Hoogland wrote: > >> I will not do it in one commit, if we insist on a PR i will do 73 commits >> in one PR. >> > > are you automat

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread sebgoa
On Jul 7, 2015, at 12:10 PM, Daan Hoogland wrote: > I will not do it in one commit, if we insist on a PR i will do 73 commits > in one PR. > are you automating those commits ? I would not mind scanning through them and giving green light. and in that case squash might be good :) > On Tue, J

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Daan Hoogland
I will not do it in one commit, if we insist on a PR i will do 73 commits in one PR. On Tue, Jul 7, 2015 at 12:04 PM, Rohit Yadav wrote: > > On 07-Jul-2015, at 3:29 pm, Daan Hoogland wrote: > > I want permission to go ahead and address these issues and not create > one huge or 73 small PRs. Can

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Rohit Yadav
On 07-Jul-2015, at 3:29 pm, Daan Hoogland mailto:daan.hoogl...@gmail.com>> wrote: I want permission to go ahead and address these issues and not create one huge or 73 small PRs. Can I? One huge commit would be fine, testing/merging 73 small PRs is going to be some work. Regards, Rohit Yadav S