Re: help submitting to review board.

2013-07-29 Thread Min Chen
The person who reviewed and approved should commit the patch for you. Thanks -min On 7/29/13 5:40 PM, "Thomas O'Dowd" wrote: >Hi all, > >I'm wondering what the next steps on this[1] review is. I think someone >needs to merge the patch in before I close but I'm not sure what the >flow is. Maybe

Re: help submitting to review board.

2013-07-29 Thread Thomas O'Dowd
Hi all, I'm wondering what the next steps on this[1] review is. I think someone needs to merge the patch in before I close but I'm not sure what the flow is. Maybe I need to close as submitted first? Can someone advise? Thanks, Tom. [1] https://reviews.apache.org/r/12963/ On Fri, 2013-07-26 at

Re: help submitting to review board.

2013-07-26 Thread Thomas O'Dowd
Hi John, https://reviews.apache.org/r/12963/ Tom. On Jul 26, 2013, at 23:20, John Burwell wrote: > Thomas, > > What is the link to your review request? > > Thanks, > -John > > On Jul 26, 2013, at 5:10 AM, Thomas O'Dowd wrote: > >> That worked a charm! Thanks. I also *blush* just re-read

Re: help submitting to review board.

2013-07-26 Thread John Burwell
Thomas, What is the link to your review request? Thanks, -John On Jul 26, 2013, at 5:10 AM, Thomas O'Dowd wrote: > That worked a charm! Thanks. I also *blush* just re-read the > instructions on this page: > http://cloudstack.apache.org/develop/non-committer.html > > Thanks again. > > Tom. >

Re: help submitting to review board.

2013-07-26 Thread Thomas O'Dowd
That worked a charm! Thanks. I also *blush* just re-read the instructions on this page: http://cloudstack.apache.org/develop/non-committer.html Thanks again. Tom. On Fri, 2013-07-26 at 09:06 +, Rajesh Battala wrote: > In the groups, use "cloudstack" > This should be enough to create the req

RE: help submitting to review board.

2013-07-26 Thread Rajesh Battala
In the groups, use "cloudstack" This should be enough to create the request. Thanks Rajesh Battala > -Original Message- > From: Thomas O'Dowd [mailto:tpod...@cloudian.com] > Sent: Friday, July 26, 2013 2:34 PM > To: Cloudstack DEV > Subject: help submitting to review board. > > I'm try