Re: disk_io_throttle and solidfire Patch Review Status

2013-06-20 Thread Mike Tutkowski
No problem :) Just wanted to let you know that it's there and that I believe I've completed all of what you, Wei, and I talked about. Thanks! On Thu, Jun 20, 2013 at 11:42 AM, John Burwell wrote: > Mike, > > I am booked up this afternoon. I will start my review tomorrow and > complete as nec

Re: disk_io_throttle and solidfire Patch Review Status

2013-06-20 Thread Mike Tutkowski
You've possibly seen the auto-generated e-mail that I updated Review Board with a new diff. This third diff is comprehensive in that it includes all of the changes I've made for this feature. I believe I have now completed all actions that were required of me. Please let me know if you have quest

Re: disk_io_throttle and solidfire Patch Review Status

2013-06-20 Thread John Burwell
Mike, I am booked up this afternoon. I will start my review tomorrow and complete as necessary on the flight Saturday. Thanks, -John On Jun 20, 2013, at 1:39 PM, Mike Tutkowski wrote: > You've possibly seen the auto-generated e-mail that I updated Review Board > with a new diff. This third

Re: disk_io_throttle and solidfire Patch Review Status

2013-06-19 Thread Mike Tutkowski
Well...it's not "necessary" per se. :) I just wanted to throw it out there and get people's thoughts. I certainly don't want to take anything away from your feature that you may value a lot. On Wed, Jun 19, 2013 at 2:03 PM, Wei ZHOU wrote: > Mike, > > You can remove them from UI if necessary. >

Re: disk_io_throttle and solidfire Patch Review Status

2013-06-19 Thread Mike Tutkowski
One thing I have been noticing is that there are now a lot of columns in the Service Offerings - Disk Offerings table since Wei's four hypervisor QoS fields are there. I don't know if others have observed this, but this many columns seems to skew the table a bit: The columns don't entirely line up.

Re: disk_io_throttle and solidfire Patch Review Status

2013-06-19 Thread Mike Tutkowski
Maybe I'll just have to start doing bold like this: Bold even if it just displays as text. :) On Wed, Jun 19, 2013 at 10:36 AM, Chip Childers wrote: > On Wed, Jun 19, 2013 at 10:34:58AM -0600, Mike Tutkowski wrote: > > Comments below in red. > > We can't see the red for text emails. ;-) > --

Re: disk_io_throttle and solidfire Patch Review Status

2013-06-19 Thread Chip Childers
On Wed, Jun 19, 2013 at 10:34:58AM -0600, Mike Tutkowski wrote: > Comments below in red. We can't see the red for text emails. ;-)

Re: disk_io_throttle and solidfire Patch Review Status

2013-06-19 Thread Mike Tutkowski
Comments below in red. Thanks On Wed, Jun 19, 2013 at 8:35 AM, John Burwell wrote: > All, > > Since the threads discussing these patches have been very long, I want to > roll up the issue list, and ensure that we are on track to have them > resolved before the 4.2. The following is my current