Yes. we do need to fix such kind of typo
> -Original Message-
> From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
> Sent: Friday, July 19, 2013 12:28 AM
> To: dev@cloudstack.apache.org
> Subject: RE: code formatting for enums
>
> > -Original Message---
ginal Message-
>> From: Alex Huang [mailto:alex.hu...@citrix.com]
>> Sent: Friday, July 19, 2013 8:38 AM
>> To: dev@cloudstack.apache.org
>> Subject: RE: code formatting for enums
>>
>> John,
>>
>> Just to be clear. Not doing enum change correctly can
amework like
the DAO layer that already defined how to deal with enums. And also, API also
needs i18n etc. That side probably require a discussion.
--Alex
> -Original Message-
> From: John Burwell [mailto:jburw...@basho.com]
> Sent: Friday, July 19, 2013 12:06 PM
> To:
m convention is all
capitalized.
> -Original Message-
> From: Alex Huang [mailto:alex.hu...@citrix.com]
> Sent: Friday, July 19, 2013 8:38 AM
> To: dev@cloudstack.apache.org
> Subject: RE: code formatting for enums
>
> John,
>
> Just to be clear. Not doing enu
o.com]
> Sent: Friday, July 19, 2013 6:33 AM
> To: dev@cloudstack.apache.org
> Subject: Re: code formatting for enums
>
> Frank,
>
> I expect that renaming an enum value to be a minor change (i.e. once the
> codebase compiles, the change is good). However, i can say I am surp
--Original Message-
>> From: John Burwell [mailto:jburw...@basho.com]
>> Sent: Thursday, July 18, 2013 4:39 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: code formatting for enums
>>
>> Alex and Frank,
>>
>> In terms of conventions, the
2013 12:19 AM
> > To: dev@cloudstack.apache.org
> > Subject: RE: code formatting for enums
> >
> > Then the most important factor of name
> > convention is user experience where Running is more user friendly than
> > IS_RUNNING or whatever all capitalized sentence
> -Original Message-
> From: Frank Zhang [mailto:frank.zh...@citrix.com]
> Sent: 19 July 2013 12:19 AM
> To: dev@cloudstack.apache.org
> Subject: RE: code formatting for enums
>
> Then the most important factor of name
> convention is user experience where Runni
4:39 PM
> To: dev@cloudstack.apache.org
> Subject: Re: code formatting for enums
>
> Alex and Frank,
>
> In terms of conventions, the APIs exposed Java SDK and many other common
> APIs following this convention. Hence, the reason for my suggestion.
>
> The notion that
uldn't expose states directly to end
users. That really does require a discussion thread.
--Alex
> -Original Message-
> From: John Burwell [mailto:jburw...@basho.com]
> Sent: Thursday, July 18, 2013 4:39 PM
> To: dev@cloudstack.apache.org
> Subject: Re: code
ts if the only reason is to follow some name
> convention.
>
>> -Original Message-
>> From: Alex Huang [mailto:alex.hu...@citrix.com]
>> Sent: Thursday, July 18, 2013 3:55 PM
>> To: dev@cloudstack.apache.org
>> Subject: RE: code formatting for enums
>>
5 PM
> To: dev@cloudstack.apache.org
> Subject: RE: code formatting for enums
>
> Actually, that's more of a C/C++ coding convention. (Speaking of which,
> please
> don't use "I" to start interfaces.)
>
> I prefer to have enums as follows
>
ohn Burwell [mailto:jburw...@basho.com]
> Sent: Thursday, July 18, 2013 12:33 PM
> To: dev@cloudstack.apache.org
> Subject: Re: code formatting for enums
>
> All,
>
> Another thing I have noticed is that enum values are not capitalized. General
> coding convention is that
way.
>
> --Alex
>
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: Wednesday, July 17, 2013 8:23 AM
>> To: dev
>> Subject: Re: code formatting for enums
>>
>> thanks,
>> it doesn't correct b
com]
> Sent: Wednesday, July 17, 2013 8:23 AM
> To: dev
> Subject: Re: code formatting for enums
>
> thanks,
> it doesn't correct back to the one per line format, but at least it doesn't
> garble the enum when right anymore.
>
>
>
> On Wed, Jul 17, 2013 at 4
thanks,
it doesn't correct back to the one per line format, but at least it doesn't
garble the enum when right anymore.
On Wed, Jul 17, 2013 at 4:24 PM, Alex Huang wrote:
> Windows->Preferences
> Java->Formatter
> Click on Edit in Active Profiles
> Line Wrapping tab
> Look for 'enum' declarati
Windows->Preferences
Java->Formatter
Click on Edit in Active Profiles
Line Wrapping tab
Look for 'enum' declaration->Constants
Select Wrap all elements, every element on a new line in the "Line Wrapping
policy:" drop down
--Alex
> -Original Message-
> From: Daan Hoogland [mailto:daan.ho
17 matches
Mail list logo
