Re: Yet another mail on code quality

2014-02-26 Thread Hugo Trippaers
Thank Rajani! I’ve put the information on using FindBugs here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+FindBugs Cheers, Hugo On 26 feb. 2014, at 07:31, Rajani Karuturi wrote: > intellij findbugs plugin can be downloaded @ > http://plugins.jetbrains.com/plugin/3847 > onc

Re: Yet another mail on code quality

2014-02-25 Thread Rajani Karuturi
intellij findbugs plugin can be downloaded @ http://plugins.jetbrains.com/plugin/3847 once its installed, you can right click on the file -> FindBugs -> Analyze current file This will show the results in the find bugs console with a nice explanation for each error. you could also run $mvn findb

Re: Yet another mail on code quality

2014-02-25 Thread Abhinandan Prateek
Hugo, It will benefit the community if you can advise on how to setup the find bug tool. Is there a wiki on how to use find bug ? I know some tools that you can install on eclipse, but not sure about intellij etc. -abhi On 24/02/14 9:44 pm, "Hugo Trippaers" wrote: >Guys, > >Please pay atten

Re: Yet another mail on code quality

2014-02-24 Thread Marcus
Sometimes it's not easy to revert the commit, I suppose a bug should be raised and assigned to the individual, in that case. For example, someone branches and then merges without pulling in fixes that occurred in between, this is fairly common and can be painful when file locations are shifted arou

RE: Yet another mail on code quality

2014-02-24 Thread Alex Huang
I think we should just revert the commits on problems. It actually helps the developers because it gives them a chance to redo it in the correct way and hopefully, they gain more understanding of what needs to be done. At worst, they will remember if penalized enough times. Sometimes, tough l

Re: Yet another mail on code quality

2014-02-24 Thread Laszlo Hornyak
Hi, Guys if you feel like, look around in sonar sometimes, it registers and tracks tons of such issues (and the app is cool, nice and super-trendy) https://analysis.apache.org/dashboard/index/100206 For incorrect use of == operator, sonar knows 14 more cases in ACS, There are some that "not nice