Rohit,
There are no code changes to util.pread2, so what you're observing would
have to be an artifact of either stdout changing, or how popen.communicate
handles the trailing newline from the actual command. Regardless, your
solution should take care of both cases.
For the ## Discuss, I think w
Hi Tim,
Thanks for your review. I’ve fixed the tick-quote issue on the mentioned line.
Please find the various issues addressed in this patch;
## 1. Issue with sm/util.py
My concern with sm/util.py was that, previously on XS 6.2 the output of a
typical util.pread2().split(‘\n’) would return a
Rohit,
I just added a comment to update line 457 to tick-quote the vmchain as
you've done elsewhere. My main concern would be flushing the ipset while
the iptable entry still exists.
I am curious what in sm/util.py concerned you. That's all storage
management code and should have nothing to do
