Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-21 Thread Daniel Vega Simoes
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-21 Thread Rohit Yadav
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-20 Thread Rohit Yadav
Thanks Daniel, I’ll test this by tomorrow. Cheers. On 20-Aug-2014, at 9:21 pm, Daniel Vega Simoes wrote: > > >> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: >>> Hi Daniel, >>> >>> Thank you for your work, it looks comprehensive. Appreciate the tests and >>> design doc on the wiki. >>> >>>

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-20 Thread Daniel Vega Simoes
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-20 Thread Daniel Vega Simoes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/ --- (Updated Aug. 20, 2014, 7:18 p.m.) Review request for cloudstack, Chiradeep Vit

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-19 Thread Rohit Yadav
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-19 Thread Daniel Vega Simoes
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-19 Thread Rohit Yadav
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-14 Thread Rohit Yadav
Hey! On 14-Aug-2014, at 6:47 pm, Daniel Vega Simoes wrote: > Rohit, > > We've fired up a VM on Amazon EC2 to host both the DNS server and the > GloboDNS application that manages it. > > When you configure the GloboDNS provider, you should use the following info: > -> username: ad...@example.co

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-14 Thread Daniel Vega Simoes
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-13 Thread Rohit Yadav
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-13 Thread Daniel Vega Simoes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/ --- (Updated Aug. 13, 2014, 5:08 p.m.) Review request for cloudstack, Chiradeep Vit

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-13 Thread Daniel Vega Simoes
> On Aug. 12, 2014, 9:52 p.m., Rohit Yadav wrote: > > Hi Daniel, > > > > Thank you for your work, it looks comprehensive. Appreciate the tests and > > design doc on the wiki. > > > > Can you make sure we don't do wildcard imports, I personally don't have any > > problem with using them but a

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-13 Thread Daniel Vega Simoes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/ --- (Updated Aug. 13, 2014, 2:43 p.m.) Review request for cloudstack, Chiradeep Vit

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-13 Thread Daniel Vega Simoes
> On Aug. 13, 2014, 9:26 a.m., Rohit Yadav wrote: > > Hi Daniel, the patch is failing on current master. Please submit a > > git-formatted patch that would apply cleanly on master. Sorry about that, we were working on an outdated fork. Will produce a new patch file that applies on current mast

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-13 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/#review50437 --- Hi Daniel, the patch is failing on current master. Please submit a

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-12 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/#review50372 --- Hi Daniel, Thank you for your work, it looks comprehensive. Appreci

Re: Review Request 24611: New DNS provider (GloboDNS)

2014-08-12 Thread Daniel Vega Simoes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/ --- (Updated Aug. 12, 2014, 9:43 p.m.) Review request for cloudstack, Chiradeep Vit