Re: Review Request 22799: Golden (Base) Primary Storage feature

2015-04-06 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22799/#review79032 --- Thank you for submitting your CloudStack contribution through review

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-09-03 Thread Mike Tutkowski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22799/#review52266 --- Just checking in again to see where we're at with this feature. Tim?

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-07-20 Thread Hieu LE
kowski [mailto:mike.tutkow...@solidfire.com] >> Sent: Sunday, July 20, 2014 9:16 PM >> To: dev@cloudstack.apache.org; Hieu LE >> Cc: Tim Mackey >> Subject: Re: Review Request 22799: Golden (Base) Primary Storage feature >> >> Thanks! >> >> Adding Marv

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-07-20 Thread Mike Tutkowski
solidfire.com] > Sent: Sunday, July 20, 2014 9:16 PM > To: dev@cloudstack.apache.org; Hieu LE > Cc: Tim Mackey > Subject: Re: Review Request 22799: Golden (Base) Primary Storage feature > > Thanks! > > Adding Marvin tests is not a prerequisite to your code being committed. I

RE: Review Request 22799: Golden (Base) Primary Storage feature

2014-07-20 Thread Sudha Ponnaganti
: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Sunday, July 20, 2014 9:16 PM To: dev@cloudstack.apache.org; Hieu LE Cc: Tim Mackey Subject: Re: Review Request 22799: Golden (Base) Primary Storage feature Thanks! Adding Marvin tests is not a prerequisite to your code being committed. I

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-07-20 Thread Mike Tutkowski
Thanks! Adding Marvin tests is not a prerequisite to your code being committed. I just strongly recommend you consider such tests. Essentially it is ideal to have Marvin tests, but not required. I'm glad to see the list of tests you've performed manually. Thanks for adding that to Review Board.

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-07-20 Thread Hieu LE
> On July 18, 2014, 4:16 a.m., Mike Tutkowski wrote: > > Hi, > > > > It's been a while since we've had any activity review wise on this feature. > > > > Can you guys tell me where we're currently at? > > > > Thanks! > > Mike Sorry Mike, There are some troubles with my machines last week. I

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-07-20 Thread Hieu LE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22799/ --- (Updated July 21, 2014, 3:56 a.m.) Review request for cloudstack, Mike Tutkowsk

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-07-18 Thread Hieu LE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22799/ --- (Updated July 18, 2014, 10:26 a.m.) Review request for cloudstack, Mike Tutkows

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-07-17 Thread Mike Tutkowski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22799/#review48109 --- Hi, It's been a while since we've had any activity review wise on t

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-30 Thread Hieu LE
Tim, How can I monitor/watch the process of read-cache feature in XenServer Creedence Alpha 2 ? On Thu, Jun 26, 2014 at 10:51 AM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Thanks! I'm also curious about manual (or automated) regression testing > you may have performed. > > > On We

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-25 Thread Mike Tutkowski
Thanks! I'm also curious about manual (or automated) regression testing you may have performed. On Wed, Jun 25, 2014 at 7:52 PM, Hieu LE wrote: > Hi Tim and Mike, > > > On Tue, Jun 24, 2014 at 7:30 PM, Tim Mackey wrote: > >> Hieu, >> >> It would also be good in your design doc and testing to v

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-25 Thread Hieu LE
Hi Tim and Mike, On Tue, Jun 24, 2014 at 7:30 PM, Tim Mackey wrote: > Hieu, > > It would also be good in your design doc and testing to validate which > XenServer versions you expect this to work with, and don't forget about > xcp-xapi in pure Linux as part of that. If you have time, I'd also

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-24 Thread Tim Mackey
Hieu, It would also be good in your design doc and testing to validate which XenServer versions you expect this to work with, and don't forget about xcp-xapi in pure Linux as part of that. If you have time, I'd also be curious if XenServer Creedence Read cache has any impact on your results/imple

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-23 Thread Mike Tutkowski
Hi, Yes, Marvin is great for automated regression testing of CloudStack. However, I was hoping you could note even manual testing (new and regression tests) you may have run to verify correctness of the system within reason (even if these are not automated). If you have time, automated tests wou

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-23 Thread Hieu LE
Hi Tim and Mike, On Tue, Jun 24, 2014 at 5:59 AM, Tim Mackey wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22799/ > > On June 23rd, 2014, 9:16 p.m. UTC, *Mike Tutkowski* wrote: > > I was wondering if you could fill out the section about t

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-23 Thread Tim Mackey
> On June 23, 2014, 9:16 p.m., Mike Tutkowski wrote: > > I was wondering if you could fill out the section about tests that have > > been performed? > > > > I would be interested in both new and regression testing. > > > > Thanks! It looked like some functions added parameters, but didn't inc

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-23 Thread Mike Tutkowski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22799/#review46451 --- I was wondering if you could fill out the section about tests that h

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-19 Thread Hieu LE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22799/ --- (Updated June 20, 2014, 3:46 a.m.) Review request for cloudstack, Mike Tutkowsk

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-19 Thread Hieu LE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22799/ --- (Updated June 20, 2014, 1:54 a.m.) Review request for cloudstack, Mike Tutkowsk

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-19 Thread Hieu LE
Hi Tim, Mike, This patch apply for golden primary storage feature [1]. Please review it. [1]: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Golden+Primary+Storage On Fri, Jun 20, 2014 at 8:41 AM, Hieu LE wrote: >This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 22799: Golden (Base) Primary Storage feature

2014-06-19 Thread Hieu LE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22799/ --- (Updated June 20, 2014, 1:41 a.m.) Review request for cloudstack. Repository: