Re: Review Request 21070: Fixed few exception cases.

2014-05-14 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21070/#review42491 --- Ship it! Ship It! - Santhosh Edukulla On May 5, 2014, 6:49 a.m.,

Re: Review Request 21070: Fixed few exception cases.

2014-05-14 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21070/#review42955 --- pushed to master 24bf1c56dfe437766a716dc8ced6d892782bd6a1 - Srikan

Re: Review Request 21070: Fixed few exception cases.

2014-05-05 Thread sanjeev n
> On May 5, 2014, 4:06 p.m., sanjeev n wrote: > > Ship It! Applied patch to 4.4-automation branch commit ef286da8ccc005fee58c4be5d508c5d7ddfc2a6c Author: sanjeevneelarapu Date: Tue May 6 02:57:08 2014 +0530 Fixed few exception cases - sanjeev -

Re: Review Request 21070: Fixed few exception cases.

2014-05-05 Thread sanjeev n
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21070/#review42157 --- Ship it! Ship It! - sanjeev n On May 5, 2014, 6:49 a.m., Santhos

Re: Review Request 21070: Fixed few exception cases.

2014-05-05 Thread sanjeev n
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21070/#review42142 --- Please rebase with master since patch apply failed on master branch.

RE: Review Request 21070: Fixed few exception cases.

2014-05-05 Thread Santhosh Edukulla
From: Gaurav Aradhye [gaurav.arad...@clogeny.com] Sent: Monday, May 05, 2014 3:04 AM To: dev@cloudstack.apache.org; Santhosh Edukulla Cc: Sanjeev Neelarapu Subject: Re: Review Request 21070: Fixed few exception cases. Hi Santhosh, I would like to mention one

Re: Review Request 21070: Fixed few exception cases.

2014-05-05 Thread Gaurav Aradhye
Hi Santhosh, I would like to mention one concern here. If we are raising exception through "marvinRequest" function in cloudstackConnection.py, instead of returning FAILED, then this will need many test cases to be changed too, where we are explicitly asserting the output of particular marvin comm