Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-13 Thread Koushik Das
> On March 13, 2014, 12:19 p.m., Koushik Das wrote: > > Ship It! Commit 5779292e93fe52a7fb5ec0abffe1e3f6b9c10121 in cloudstack's branch refs/heads/master from [~koushikd] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5779292 ] CLOUDSTACK-6052: List VM enhancement to support quer

Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-13 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19022/#review37045 --- Ship it! Ship It! - Koushik Das On March 11, 2014, 6:29 a.m., Ko

Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-12 Thread Daan Hoogland
On Wed, Mar 12, 2014 at 1:13 PM, Koushik Das wrote: > [Koushik] Yes. > then ship -- Daan

Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-12 Thread Koushik Das
On 11-Mar-2014, at 7:24 PM, Daan Hoogland wrote: > You are saying it must be null and not empty? [Koushik] Yes. > > > On Tue, Mar 11, 2014 at 1:41 PM, Koushik Das wrote: > >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/19022/ >> >> On Mar

Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-11 Thread Daan Hoogland
You are saying it must be null and not empty? On Tue, Mar 11, 2014 at 1:41 PM, Koushik Das wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19022/ > > On March 11th, 2014, 7:41 a.m. UTC, *daan Hoogland* wrote: > > > server/src/com/cloud/a

Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-11 Thread Koushik Das
> On March 11, 2014, 7:41 a.m., daan Hoogland wrote: > > server/src/com/cloud/api/query/QueryManagerImpl.java, line 731 > > > > > > Why not be lenient and consider the id as part of ids? > > You are being strict on

Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-11 Thread daan Hoogland
> On March 11, 2014, 7:41 a.m., daan Hoogland wrote: > > server/src/com/cloud/api/query/QueryManagerImpl.java, line 731 > > > > > > Why not be lenient and consider the id as part of ids? > > You are being strict on

Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-11 Thread Koushik Das
> On March 11, 2014, 7:41 a.m., daan Hoogland wrote: > > server/src/com/cloud/api/query/QueryManagerImpl.java, line 731 > > > > > > Why not be lenient and consider the id as part of ids? > > You are being strict on

Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-11 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19022/#review36764 --- I will give it a test spin. I cannot judge the test script you added