Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19021/#review37582 --- Ship it! Ship It! - edison su On March 13, 2014, 9:16 a.m., puni

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19021/#review37199 --- Ship it! Ship It! - Mike Tutkowski On March 13, 2014, 9:16 a.m.,

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

hi guys, i have resolved all issues with fixes and refactoring of plugin code, its good to go now , i'll submit once i get the ship it message. thanks for the review. On Fri, Mar 14, 2014 at 11:19 AM, punith s wrote: >This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

> On March 14, 2014, 3:54 a.m., Mike Tutkowski wrote: > > plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java, > > line 99 > > > > > > Does th

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

y want. My criteria to check in the >> code is very simple: the plugin should not modify common code. >> >> >> >> *From:* Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] >> *Sent:* Thursday, March 13, 2014 3:25 PM >> *To:* Edison Su; Mike Tutkowski >> *Cc:*

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

nt. My criteria to check in the > code is very simple: the plugin should not modify common code. > > > > *From:* Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] > *Sent:* Thursday, March 13, 2014 3:25 PM > *To:* Edison Su; Mike Tutkowski > *Cc:* punith s; cloudstack > *S

RE: Review Request 19021: Cloudbyte Elastistor storage plug-in

stack Subject: Re: Review Request 19021: Cloudbyte Elastistor storage plug-in Hi Punith, Once you close out the open issues, we can work to get your code in. Feature freeze is Friday, March 14th, so we should do it sometime tomorrow. Thanks! On Thu, Mar 13, 2014 at 4:24 PM, Mike Tutk

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

Hi Punith, Once you close out the open issues, we can work to get your code in. Feature freeze is Friday, March 14th, so we should do it sometime tomorrow. Thanks! On Thu, Mar 13, 2014 at 4:24 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: >This is an automatically generated e-

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19021/#review37123 --- plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19021/#review37109 --- The patch looks OK to me. When Mike is OK with your patch, then we c

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

> On March 12, 2014, 10:19 p.m., Mike Tutkowski wrote: > > plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorUtil.java, > > line 495 > > > > > > I like how you removed the sta

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19021/ --- (Updated March 13, 2014, 2:46 p.m.) Review request for cloudstack, edison su an

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19021/ --- (Updated March 13, 2014, 12:52 p.m.) Review request for cloudstack, edison su a

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

> On March 13, 2014, 3:37 a.m., edison su wrote: > > Could you upload a new patch? I can't apply it on master branch, git > > complains that some files are not indexed. hi edison, i have added a fresh new patch like as if it's a new patch. thanks. - punith

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

> On March 12, 2014, 10:19 p.m., Mike Tutkowski wrote: > > plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorUtil.java, > > line 495 > > > > > > I like how you removed the sta

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19021/ --- (Updated March 13, 2014, 12:21 p.m.) Review request for cloudstack, edison su a

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19021/#review37004 --- Could you upload a new patch? I can't apply it on master branch, git

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19021/#review36929 --- plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

> On March 12, 2014, 7:18 a.m., Mike Tutkowski wrote: > > plugins/storage/volume/cloudbyte/pom.xml, line 1 > > > > > > Looks like the license section is having some trouble with end-line > > chars yea, checkstyle is no

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

> On March 12, 2014, 9:39 a.m., Mike Tutkowski wrote: > > plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java, > > line 345 > > > > > > Perha

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19021/ --- (Updated March 12, 2014, 9:39 p.m.) Review request for cloudstack, edison su an

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19021/#review36900 --- plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/

Re: Review Request 19021: Cloudbyte Elastistor storage plug-in

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19021/#review36891 --- plugins/storage/volume/cloudbyte/pom.xml