Re: Review Request 18066: Fixing troubling issues on contrail plugin found by FindBugs

2014-02-14 Thread Wilder Rodrigues
> On Feb. 14, 2014, 10:18 a.m., Wilder Rodrigues wrote: > > This review will be discarded. The changes for the contrail plugin were squashed with another commit. A new patch will be uploaded to the review ID 18072 - Wilder --- This is

Re: Review Request 18066: Fixing troubling issues on contrail plugin found by FindBugs

2014-02-14 Thread Wilder Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18066/#review34476 --- plugins/network-elements/juniper-contrail/src/org/apache/cloudstack

Re: Review Request 18066: Fixing troubling issues on contrail plugin found by FindBugs

2014-02-14 Thread Wilder Rodrigues
> On Feb. 14, 2014, 8:54 a.m., Hugo Trippaers wrote: > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java, > > line 81 > > > > > > Why should this be

Re: Review Request 18066: Fixing troubling issues on contrail plugin found by FindBugs

2014-02-14 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18066/#review34463 --- plugins/network-elements/juniper-contrail/src/org/apache/cloudstack