> On Nov. 20, 2013, 12:58 p.m., Ian Duffy wrote:
> > Ship It!
This commit is not pushed to 4.3 branch. can you push there as well?
- Rajani
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/155
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15572/#review29165
---
Ship it!
Ship It!
- Ian Duffy
On Nov. 15, 2013, 11:50 a.m., Raja
> On Nov. 17, 2013, 4:26 p.m., Ian Duffy wrote:
> > Rajani,
> >
> > This introduces mixing of tabs and spaces within the javascript files. Can
> > you please adjust to use spaces only?
> >
> > Other than that it looks good.
> > I will ship once I see the above fixed.
> >
> > Thanks,
> > Ian
>
> On Nov. 17, 2013, 4:26 p.m., Ian Duffy wrote:
> > Rajani,
> >
> > This introduces mixing of tabs and spaces within the javascript files. Can
> > you please adjust to use spaces only?
> >
> > Other than that it looks good.
> > I will ship once I see the above fixed.
> >
> > Thanks,
> > Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15572/#review29022
---
Rajani,
This introduces mixing of tabs and spaces within the javasc