Re: Review Request 14334: CLOUDSTACK 4705: Fixed domain memory limits test cases

2013-10-18 Thread Daan Hoogland
On Fri, Oct 18, 2013 at 11:15 AM, Gaurav Aradhye wrote: > af2646f9a813b86ad8ce2987a11e64ac45833345 H Gaurav, The cherry-picking resulted in conflicts as well. After resolving those the patch didn't apply. Can you please check if your changes are needed on master and if so resolve any conflicts?

Re: Review Request 14334: CLOUDSTACK 4705: Fixed domain memory limits test cases

2013-10-18 Thread Gaurav Aradhye
Hi Daan, One commit is missing in master involving the same file. Hence the patch is not getting applied. Can you please cherry-pick commit af2646f9a813b86ad8ce2987a11e64ac45833345 (4.2 branch) to master branch and then apply this patch on top of that? That should succeed. Regards, Gaurav On Th

Re: Review Request 14334: CLOUDSTACK 4705: Fixed domain memory limits test cases

2013-10-17 Thread Daan Hoogland
Gaurav, I will but it doesn't apply to master. Can you update it? regards, On Wed, Oct 16, 2013 at 6:43 PM, Girish Shilamkar wrote: > > >> On Oct. 8, 2013, 11:14 a.m., abhinav roy wrote: >> > Ship It! > > Can someone commit this patch. > > > - Girish > > > ---

Re: Review Request 14334: CLOUDSTACK 4705: Fixed domain memory limits test cases

2013-10-16 Thread Girish Shilamkar
> On Oct. 8, 2013, 11:14 a.m., abhinav roy wrote: > > Ship It! Can someone commit this patch. - Girish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14334/#review26770 -

Re: Review Request 14334: CLOUDSTACK 4705: Fixed domain memory limits test cases

2013-10-08 Thread abhinav roy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14334/#review26770 --- Ship it! Ship It! - abhinav roy On Sept. 25, 2013, 11:06 a.m., G