Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-07 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13252/#review24818 --- Ship it! Ship It! - Chiradeep Vittal On Aug. 7, 2013, 7:01 p.m.,

Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13252/ --- (Updated Aug. 7, 2013, 7:01 p.m.) Review request for cloudstack and John Kinsel

Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-06 Thread Demetrius Tsitrelis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13252/#review24759 --- Ship it! Ship It! - Demetrius Tsitrelis On Aug. 6, 2013, 9:59 p.

Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-06 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13252/#review24757 --- Can you add tests to AuthenticatorTest.java 1. authenticate('FooUser

Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-06 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13252/ --- (Updated Aug. 6, 2013, 9:59 p.m.) Review request for cloudstack and John Kinsel

Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-06 Thread Demetrius Tsitrelis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13252/#review24750 --- There is a problem on line 86 with the order of the test. As is the

Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-06 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13252/ --- (Updated Aug. 6, 2013, 9:51 p.m.) Review request for cloudstack and John Kinsel

Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-06 Thread Amogh Vasekar
> On Aug. 6, 2013, 8:57 p.m., Chiradeep Vittal wrote: > > plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java, > > line 43 > > > > > > What is the impact on upgrades? T

Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-06 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13252/ --- (Updated Aug. 6, 2013, 9:45 p.m.) Review request for cloudstack and John Burwel

Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-06 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13252/#review24743 --- plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/

Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-05 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13252/ --- (Updated Aug. 5, 2013, 7:06 p.m.) Review request for cloudstack and John Burwel

Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-05 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13252/ --- (Updated Aug. 5, 2013, 6:57 p.m.) Review request for cloudstack and John Burwel