Re: Review Request: Typos fixed

2013-05-30 Thread Animesh Chaturvedi
> On April 11, 2013, 1:26 p.m., Joe Brockmeier wrote: > > Hi - the content looks good, but the actual patch looks wonky. Doesn't > > apply. Can you reformat and make sure that it applies against master? > > (Actually try applying it to master as a patch, if you haven't.) Thanks! > > Pascal Bor

Re: Review Request: Typos fixed

2013-04-11 Thread Joe Brockmeier
> On April 11, 2013, 1:26 p.m., Joe Brockmeier wrote: > > Hi - the content looks good, but the actual patch looks wonky. Doesn't > > apply. Can you reformat and make sure that it applies against master? > > (Actually try applying it to master as a patch, if you haven't.) Thanks! > > Pascal Bor

Re: Review Request: Typos fixed

2013-04-11 Thread Hiroaki Kawai
If you can prepare a patch for master branch, it is welcome of course ! :-) 2013/04/11 22:45、"Pascal Borreli" のメッセージ: > > >> On April 11, 2013, 1:26 p.m., Joe Brockmeier wrote: >>> Hi - the content looks good, but the actual patch looks wonky. Doesn't >>> apply. Can you reformat and make sure

Re: Review Request: Typos fixed

2013-04-11 Thread Pascal Borreli
> On April 11, 2013, 1:26 p.m., Joe Brockmeier wrote: > > Hi - the content looks good, but the actual patch looks wonky. Doesn't > > apply. Can you reformat and make sure that it applies against master? > > (Actually try applying it to master as a patch, if you haven't.) Thanks! my original pl

Re: Review Request: Typos fixed

2013-04-11 Thread Joe Brockmeier
> On April 11, 2013, 9:45 a.m., Hiroaki Kawai wrote: > > Ship It! Hiroaki, did this patch apply for you - it didn't for me. I used "git am -3" against master. Curious what you did differently. Thanks! - Joe --- This is an automatically

Re: Review Request: Typos fixed

2013-04-11 Thread Joe Brockmeier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10411/#review19001 --- Hi - the content looks good, but the actual patch looks wonky. Doesn

Re: Review Request: Typos fixed

2013-04-11 Thread Hiroaki Kawai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10411/#review18995 --- Ship it! Ship It! - Hiroaki Kawai On April 10, 2013, 11:06 p.m.,