Re: Review Request: Cloudstack-2548 [Automation] Failed to delete public IP range

2013-05-24 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11297/#review20987 --- Ship it! 47a562a - Prasanna Santhanam On May 22, 2013, 6:25 a.m.

Re: Review Request: Cloudstack-2548 [Automation] Failed to delete public IP range

2013-05-23 Thread bharat kumar
> On May 22, 2013, 6:27 a.m., Prasanna Santhanam wrote: > > core/src/com/cloud/network/DnsMasqConfigurator.java, line 113 > > > > > > Isn't this for the dnsmasq syntax error bug? CLOUDSTACK-2606? Wrong > > patch file?

Re: Review Request: Cloudstack-2548 [Automation] Failed to delete public IP range

2013-05-21 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11297/#review20883 --- core/src/com/cloud/network/DnsMasqConfigurator.java

Re: Review Request: Cloudstack-2548 [Automation] Failed to delete public IP range

2013-05-21 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11297/ --- (Updated May 22, 2013, 6:25 a.m.) Review request for cloudstack, Abhinandan Pra

Re: Review Request: Cloudstack-2548 [Automation] Failed to delete public IP range

2013-05-21 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11297/ --- (Updated May 22, 2013, 6:19 a.m.) Review request for cloudstack, Abhinandan Pra

Re: Review Request: Cloudstack-2548 [Automation] Failed to delete public IP range

2013-05-21 Thread Prasanna Santhanam
> On May 21, 2013, 8:53 a.m., Prasanna Santhanam wrote: > > Please add > > > > BUG-ID: Fix summary > > > > Detail > > > > This enables the commit to go against the JIRA ticket through git2jira. > > Plus it also helps explain the fix better than 'bvt-fix' > > > > > > Prasanna Santhanam wro

Re: Review Request: Cloudstack-2548 [Automation] Failed to delete public IP range

2013-05-21 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11297/ --- (Updated May 21, 2013, 9:44 a.m.) Review request for cloudstack, Abhinandan Pra

Re: Review Request: Cloudstack-2548 [Automation] Failed to delete public IP range

2013-05-21 Thread Prasanna Santhanam
> On May 21, 2013, 8:53 a.m., Prasanna Santhanam wrote: > > Please add > > > > BUG-ID: Fix summary > > > > Detail > > > > This enables the commit to go against the JIRA ticket through git2jira. > > Plus it also helps explain the fix better than 'bvt-fix' > > > > I'd run the checkin tests

Re: Review Request: Cloudstack-2548 [Automation] Failed to delete public IP range

2013-05-21 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11297/#review20832 --- Please add BUG-ID: Fix summary Detail This enables the commit t