Re: Clarification on github or and TravisCI

2014-09-03 Thread David Nalley
On Wed, Sep 3, 2014 at 7:15 AM, Ian Duffy wrote: >> It's doable but have not yet discussed and voted if we wanted to make it > an official mechanism. > > Would love to see it happen. I recall review board being a massive pain > point for a few reasons: > > 1) Large patches fail to upload, especial

Re: Clarification on github or and TravisCI

2014-09-03 Thread Erik Weber
On Wed, Sep 3, 2014 at 1:15 PM, Ian Duffy wrote: > > It's doable but have not yet discussed and voted if we wanted to make it > an official mechanism. > > Would love to see it happen. I recall review board being a massive pain > point for a few reasons: > > +1 as a non-committer it is far easier

Re: Clarification on github or and TravisCI

2014-09-03 Thread Ian Duffy
> It's doable but have not yet discussed and voted if we wanted to make it an official mechanism. Would love to see it happen. I recall review board being a massive pain point for a few reasons: 1) Large patches fail to upload, especially if they contain images. I recall sending many patches by e

Re: Clarification on github or and TravisCI

2014-09-03 Thread Sebastien Goasguen
On Sep 2, 2014, at 12:31 PM, Stephen Turner wrote: > So just to be clear, Sebastien, does that mean it's acceptable for > non-committers to submit their code for review via a Github pull request, > instead of using ReviewBoard? (I hope so: I think that will make the process > easier and so en

RE: Clarification on github or and TravisCI

2014-09-02 Thread Stephen Turner
So just to be clear, Sebastien, does that mean it's acceptable for non-committers to submit their code for review via a Github pull request, instead of using ReviewBoard? (I hope so: I think that will make the process easier and so encourage contributions). -- Stephen Turner -Original Me